Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2392283005: Reland "Merge of CrossSiteResourceHandler and NavigationResourceThrottle." (Closed)

Created:
4 years, 2 months ago by clamy
Modified:
4 years, 2 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, tburkard+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), gavinp+prer_chromium.org, jochen+watch_chromium.org, darin-cc_chromium.org, mmenke, devtools-reviews_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, Peter Beverloo, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Merge of CrossSiteResourceHandler and NavigationResourceThrottle." This relands https://codereview.chromium.org/2321543002/ that was reverted by https://codereview.chromium.org/2397893002/. The original was reverted because it landed to close to branch point, and we want to give it more time on the dev branch to fix issues that can potentially arise. This CL relands it now that the branch has been cut. BUG=621856 TBR=sky@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301 Cr-Commit-Position: refs/heads/master@{#423979}

Patch Set 1 : Original patch #

Patch Set 2 : Added debugging code from issue 2393903002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -824 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/crossProcessAbort/test_crossProcessAbort.js View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download
D content/browser/frame_host/cross_site_transferring_request.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/frame_host/cross_site_transferring_request.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 7 chunks +57 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 11 chunks +141 lines, -13 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 4 chunks +7 lines, -17 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 8 chunks +29 lines, -38 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/loader/cross_site_resource_handler.h View 1 chunk +0 lines, -97 lines 0 comments Download
D content/browser/loader/cross_site_resource_handler.cc View 1 chunk +0 lines, -388 lines 0 comments Download
M content/browser/loader/navigation_resource_throttle.h View 1 chunk +11 lines, -0 lines 0 comments Download
M content/browser/loader/navigation_resource_throttle.cc View 10 chunks +62 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 4 chunks +2 lines, -28 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 18 chunks +7 lines, -66 lines 0 comments Download
M content/browser/loader/resource_loader.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/loader/resource_loader.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +11 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 8 chunks +62 lines, -11 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
clamy
@nasko, creis: PTAL. I've added the debugging code to the reland.
4 years, 2 months ago (2016-10-06 10:03:23 UTC) #6
nasko
LGTM
4 years, 2 months ago (2016-10-07 14:07:21 UTC) #9
Charlie Reis
LGTM
4 years, 2 months ago (2016-10-07 20:48:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392283005/20001
4 years, 2 months ago (2016-10-07 22:01:54 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 22:10:17 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 22:12:01 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301
Cr-Commit-Position: refs/heads/master@{#423979}

Powered by Google App Engine
This is Rietveld 408576698