Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: android_webview/browser/gl_view_renderer_manager.cc

Issue 255783007: Leak instead of deadlock if executeHardwareAction fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/gl_view_renderer_manager.h ('k') | android_webview/browser/hardware_renderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/gl_view_renderer_manager.cc
diff --git a/android_webview/browser/gl_view_renderer_manager.cc b/android_webview/browser/gl_view_renderer_manager.cc
index 13a60fd1fab82d98e6624acadfb54666125c6e7b..1aa4199112e7073f77626992a8699ccf16264b28 100644
--- a/android_webview/browser/gl_view_renderer_manager.cc
+++ b/android_webview/browser/gl_view_renderer_manager.cc
@@ -25,20 +25,7 @@ GLViewRendererManager::GLViewRendererManager() {}
GLViewRendererManager::~GLViewRendererManager() {}
-bool GLViewRendererManager::OnRenderThread() const {
- AutoLock auto_lock(lock_);
- return render_thread_.is_equal(base::PlatformThread::CurrentHandle());
-}
-
-void GLViewRendererManager::MarkRenderThread() {
- lock_.AssertAcquired();
- if (render_thread_.is_null())
- render_thread_ = base::PlatformThread::CurrentHandle();
- DCHECK(render_thread_.is_equal(base::PlatformThread::CurrentHandle()));
-}
-
GLViewRendererManager::Key GLViewRendererManager::PushBack(RendererType view) {
- MarkRenderThread();
DCHECK(mru_list_.end() ==
std::find(mru_list_.begin(), mru_list_.end(), view));
mru_list_.push_back(view);
« no previous file with comments | « android_webview/browser/gl_view_renderer_manager.h ('k') | android_webview/browser/hardware_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698