Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.h

Issue 2557773004: Remove unused lazyAppend from StyleResolver. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.h
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.h b/third_party/WebKit/Source/core/css/resolver/StyleResolver.h
index 8b79e49106e9a4f568e35bef5e8955703af4bfac..98fdb63e7fe99190b090fb4526424b342689b049 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.h
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.h
@@ -44,7 +44,6 @@ namespace blink {
class AnimatableValue;
class CSSRuleList;
-class CSSStyleSheet;
class CSSValue;
class Document;
class Element;
@@ -103,18 +102,6 @@ class CORE_EXPORT StyleResolver final
static PassRefPtr<ComputedStyle> styleForDocument(Document&);
- // FIXME: It could be better to call appendAuthorStyleSheets() directly after
- // we factor StyleResolver further.
- // https://bugs.webkit.org/show_bug.cgi?id=108890
- void appendAuthorStyleSheets(const HeapVector<Member<CSSStyleSheet>>&);
- void lazyAppendAuthorStyleSheets(unsigned firstNew,
- const HeapVector<Member<CSSStyleSheet>>&);
- void removePendingAuthorStyleSheets(const HeapVector<Member<CSSStyleSheet>>&);
- void appendPendingAuthorStyleSheets();
- bool hasPendingAuthorStyleSheets() const {
- return m_pendingStyleSheets.size() > 0;
- }
-
// TODO(esprehn): StyleResolver should probably not contain tree walking
// state, instead we should pass a context object during recalcStyle.
SelectorFilter& selectorFilter() { return m_selectorFilter; }
@@ -182,8 +169,6 @@ class CORE_EXPORT StyleResolver final
void loadPendingResources(StyleResolverState&);
void adjustComputedStyle(StyleResolverState&, Element*);
- void appendCSSStyleSheet(CSSStyleSheet&);
-
void collectPseudoRulesForElement(const Element&,
ElementRuleCollector&,
PseudoId,
@@ -320,8 +305,6 @@ class CORE_EXPORT StyleResolver final
Member<Document> m_document;
SelectorFilter m_selectorFilter;
- HeapListHashSet<Member<CSSStyleSheet>, 16> m_pendingStyleSheets;
-
Member<StyleRuleUsageTracker> m_tracker;
bool m_printMediaType = false;

Powered by Google App Engine
This is Rietveld 408576698