Remove webkitAudoContext and webkitOfflineAudioContext

Remove webkitAudoContext and webkitOfflineAudioContext

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37BAAJ

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887
Committed: https://crrev.com/f58de349230213827cd1e057d10b7a61411c328a
Cr-Commit-Position: refs/heads/master@{#438987}

[Raymond Toy, 2016-12-12 23:34:50]

Description was changed from

==========
Remove webkitAudoContext and webkitOfflineAudioContext

BUG=665887
==========

to

==========
Remove webkitAudoContext and webkitOfflineAudioContext

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37...

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887
==========

[Raymond Toy, 2016-12-12 23:35:05]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 23:37:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:31:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[foolip, 2016-12-13 07:52:18]

foolip@chromium.org changed reviewers:
+ foolip@chromium.org

[foolip, 2016-12-13 07:52:19]

https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (left):

https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:8:
[MeasureAs=AudioContext] attribute AudioContextConstructor AudioContext;
You can now remove this and remove [NoInterfaceObject] from
(Offline)AudioContext.idl. This will also drop the use counters for unprefixed,
but since they're measuring any access to window.(Offline)AudioContext they're
not really that useful.

If you want to keep some use counters, I suggest adding just [Measure] to the
interfaces, as in MessageChannel.idl. That will measure the constructors.
(Reusing the same counters is probably not a good idea, as it would like a
sudden change in usage in the graphs.)

https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:10:
[DeprecateAs=PrefixedAudioContext] attribute AudioContextConstructor
webkitAudioContext;
Also remove use counters from UseCounter.h.

[Raymond Toy, 2016-12-13 16:08:34]

https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (left):

https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:8:
[MeasureAs=AudioContext] attribute AudioContextConstructor AudioContext;
On 2016/12/13 07:52:19, foolip wrote:
> You can now remove this and remove [NoInterfaceObject] from
> (Offline)AudioContext.idl. This will also drop the use counters for
unprefixed,
> but since they're measuring any access to window.(Offline)AudioContext they're
> not really that useful.
> 
> If you want to keep some use counters, I suggest adding just [Measure] to the
> interfaces, as in MessageChannel.idl. That will measure the constructors.
> (Reusing the same counters is probably not a good idea, as it would like a
> sudden change in usage in the graphs.)

Should I also remove [NoInterfaceObject] from AudioContext.idl?

Yes, we'd like to keep use counters.  [Measure] on the interfaces is fine.  Do I
need to modify UseCounters.h to add something for these?

[Raymond Toy, 2016-12-13 16:40:59]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:41:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 16:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 16:43:53]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Raymond Toy, 2016-12-13 16:54:01]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:54:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 18:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 18:49:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[foolip, 2016-12-13 20:28:09]

https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (left):

https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:8:
[MeasureAs=AudioContext] attribute AudioContextConstructor AudioContext;
On 2016/12/13 16:08:34, Raymond Toy wrote:
> On 2016/12/13 07:52:19, foolip wrote:
> > You can now remove this and remove [NoInterfaceObject] from
> > (Offline)AudioContext.idl. This will also drop the use counters for
> unprefixed,
> > but since they're measuring any access to window.(Offline)AudioContext
they're
> > not really that useful.
> > 
> > If you want to keep some use counters, I suggest adding just [Measure] to
the
> > interfaces, as in MessageChannel.idl. That will measure the constructors.
> > (Reusing the same counters is probably not a good idea, as it would like a
> > sudden change in usage in the graphs.)
> 
> Should I also remove [NoInterfaceObject] from AudioContext.idl?
> 
> Yes, we'd like to keep use counters.  [Measure] on the interfaces is fine.  Do
I
> need to modify UseCounters.h to add something for these?

Do you want to measure how often people look at window.AudioContext? Note that
counters of this sort are greatly inflated by code that just enumerates all
properties on window, and so aren't particularly interesting.

If measuring how often the constructors are actually used is good enough, it
would be great if you could remove [NoInterfaceObject] for AudioContent.idl
together with these bits in this file. If you use [Measure] in AudioContext.idl,
the name of the use counter will be generated, V8AudioContext_Constructor I
think. You'll need to add those to UseCounter.h, and remove the 4 entries that
become unused. (But don't remove them from histograms.xml because reasons.)

[Raymond Toy, 2016-12-13 20:41:21]

On 2016/12/13 20:28:09, foolip wrote:
>
https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (left):
> 
>
https://codereview.chromium.org/2557523002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:8:
> [MeasureAs=AudioContext] attribute AudioContextConstructor AudioContext;
> On 2016/12/13 16:08:34, Raymond Toy wrote:
> > On 2016/12/13 07:52:19, foolip wrote:
> > > You can now remove this and remove [NoInterfaceObject] from
> > > (Offline)AudioContext.idl. This will also drop the use counters for
> > unprefixed,
> > > but since they're measuring any access to window.(Offline)AudioContext
> they're
> > > not really that useful.
> > > 
> > > If you want to keep some use counters, I suggest adding just [Measure] to
> the
> > > interfaces, as in MessageChannel.idl. That will measure the constructors.
> > > (Reusing the same counters is probably not a good idea, as it would like a
> > > sudden change in usage in the graphs.)
> > 
> > Should I also remove [NoInterfaceObject] from AudioContext.idl?
> > 
> > Yes, we'd like to keep use counters.  [Measure] on the interfaces is fine. 
Do
> I
> > need to modify UseCounters.h to add something for these?
> 
> Do you want to measure how often people look at window.AudioContext? Note that
> counters of this sort are greatly inflated by code that just enumerates all
> properties on window, and so aren't particularly interesting.
> 
> If measuring how often the constructors are actually used is good enough, it
> would be great if you could remove [NoInterfaceObject] for AudioContent.idl
> together with these bits in this file. If you use [Measure] in
AudioContext.idl,
> the name of the use counter will be generated, V8AudioContext_Constructor I
> think. You'll need to add those to UseCounter.h, and remove the 4 entries that
> become unused. (But don't remove them from histograms.xml because reasons.)

Constructors are actually more important, I think.

I think I've made the suggested changes in PS3.  Now to get all the tests
fixed....

[foolip, 2016-12-13 20:44:48]

lgtm % NoInterfaceObject, and I assume any test failures will just be removing
prefixes. Thanks for taking care of this!

https://codereview.chromium.org/2557523002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):

https://codereview.chromium.org/2557523002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioContext.idl:33:
NoInterfaceObject,
Also remove NoInterfaceObject

https://codereview.chromium.org/2557523002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (right):

https://codereview.chromium.org/2557523002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:8: attribute
AudioContextConstructor AudioContext;
With NoInterfaceObject gone, this will also not be needed.

[Raymond Toy, 2016-12-14 18:38:11]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2016-12-14 18:38:12]

tkent: PTAL at the webexposed layout test results.

[Raymond Toy, 2016-12-14 18:40:48]

rtoy@chromium.org changed reviewers:
+ haraken@chromium.org

[Raymond Toy, 2016-12-14 18:40:49]

haraken: PTAL at histograms.xml

[tkent, 2016-12-14 22:52:49]

lgtm

https://codereview.chromium.org/2557523002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2557523002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:87595: </enum>
Add OBSOLETE_ prefixes to 652-655?

[foolip, 2016-12-14 23:32:02]

https://codereview.chromium.org/2557523002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2557523002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:87595: </enum>
On 2016/12/14 22:52:49, tkent wrote:
> Add OBSOLETE_ prefixes to 652-655?

Huh, I didn't know people were doing this, but I see
OBSOLETE_FormSubmissionNotInDocumentTree. Could the update script be taught to
do this automatically?

[haraken, 2016-12-14 23:49:32]

LGTM

[Raymond Toy, 2016-12-14 23:53:13]

https://codereview.chromium.org/2557523002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2557523002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:87595: </enum>
On 2016/12/14 23:32:01, foolip wrote:
> On 2016/12/14 22:52:49, tkent wrote:
> > Add OBSOLETE_ prefixes to 652-655?
> 
> Huh, I didn't know people were doing this, but I see
> OBSOLETE_FormSubmissionNotInDocumentTree. Could the update script be taught to
> do this automatically?

That would be awesome, but I'm doing this manually now.

(I've often wished that the update script ran automatically so I don't have to. 
But that's a different issue.)

[Raymond Toy, 2016-12-14 23:54:04]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-12-14 23:54:04]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org,
tkent@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2557523002/#ps80001
(title: "Add OBSOLETE for obsolete WebAudio entries.")

[commit-bot: I haz the power, 2016-12-14 23:54:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:57:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Raymond Toy, 2016-12-15 22:01:37]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-12-15 22:01:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2557523002/#ps120001
(title: "Rebaseline test")

[commit-bot: I haz the power, 2016-12-15 22:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 02:14:10]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481839297413810,
"parent_rev": "7afab552b9d7d1710b8a82e977eeb6c4ebbde429", "commit_rev":
"9e16575758daa8327d6928e3c61c115f5fb5667d"}

[commit-bot: I haz the power, 2016-12-16 02:14:56]

Description was changed from

==========
Remove webkitAudoContext and webkitOfflineAudioContext

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37...

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887
==========

to

==========
Remove webkitAudoContext and webkitOfflineAudioContext

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37...

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887

Review-Url: https://codereview.chromium.org/2557523002
==========

[commit-bot: I haz the power, 2016-12-16 02:14:57]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-16 02:17:54]

Description was changed from

==========
Remove webkitAudoContext and webkitOfflineAudioContext

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37...

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887

Review-Url: https://codereview.chromium.org/2557523002
==========

to

==========
Remove webkitAudoContext and webkitOfflineAudioContext

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37...

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887

Committed: https://crrev.com/f58de349230213827cd1e057d10b7a61411c328a
Cr-Commit-Position: refs/heads/master@{#438987}
==========

[commit-bot: I haz the power, 2016-12-16 02:17:55]

Patchset 7 (id:??) landed as
https://crrev.com/f58de349230213827cd1e057d10b7a61411c328a
Cr-Commit-Position: refs/heads/master@{#438987}