Remove webkitAudoContext and webkitOfflineAudioContext

third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 [
     ImplementedAs=DOMWindowWebAudio,
 ] partial interface Window {
     [MeasureAs=AudioContext] attribute AudioContextConstructor AudioContext;

[foolip, 2016/12/13 07:52:19]

You can now remove this and remove [NoInterfaceObject] from
(Offline)AudioContext.idl. This will also drop the use counters for unprefixed,
but since they're measuring any access to window.(Offline)AudioContext they're
not really that useful.

If you want to keep some use counters, I suggest adding just [Measure] to the
interfaces, as in MessageChannel.idl. That will measure the constructors.
(Reusing the same counters is probably not a good idea, as it would like a
sudden change in usage in the graphs.)

[Raymond Toy, 2016/12/13 16:08:34]

Should I also remove [NoInterfaceObject] from AudioContext.idl?

Yes, we'd like to keep use counters.  [Measure] on the interfaces is fine.  Do I
need to modify UseCounters.h to add something for these?

[foolip, 2016/12/13 20:28:09]

Do you want to measure how often people look at window.AudioContext? Note that
counters of this sort are greatly inflated by code that just enumerates all
properties on window, and so aren't particularly interesting.

If measuring how often the constructors are actually used is good enough, it
would be great if you could remove [NoInterfaceObject] for AudioContent.idl
together with these bits in this file. If you use [Measure] in AudioContext.idl,
the name of the use counter will be generated, V8AudioContext_Constructor I
think. You'll need to add those to UseCounter.h, and remove the 4 entries that
become unused. (But don't remove them from histograms.xml because reasons.)

     [MeasureAs=OfflineAudioContext] attribute OfflineAudioContextConstructor OfflineAudioContext;
-    [DeprecateAs=PrefixedAudioContext] attribute AudioContextConstructor webkitAudioContext;

[foolip, 2016/12/13 07:52:19]

Also remove use counters from UseCounter.h.

-    [DeprecateAs=PrefixedOfflineAudioContext] attribute OfflineAudioContextConstructor webkitOfflineAudioContext;
 
     // The individual constructible AudioNodes.
     [MeasureAs=WebAudioAnalyserNode] attribute AnalyserNodeConstructor AnalyserNode;
     [MeasureAs=WebAudioAudioBuffer] attribute AudioBufferConstructor AudioBuffer;
     [MeasureAs=WebAudioAudioBufferSourceNode] attribute AudioBufferSourceNodeConstructor AudioBufferSourceNode;
     [MeasureAs=WebAudioBiquadFilterNode] attribute BiquadFilterNodeConstructor BiquadFilterNode;
     [MeasureAs=WebAudioChannelMergerNode] attribute ChannelMergerNodeConstructor ChannelMergerNode;
     [MeasureAs=WebAudioChannelSplitterNode] attribute ChannelSplitterNodeConstructor ChannelSplitterNode;
     [MeasureAs=WebAudioConstantSourceNode] attribute ConstantSourceNodeConstructor ConstantSourceNode;
     [MeasureAs=WebAudioConvolverNode] attribute ConvolverNodeConstructor ConvolverNode;
     [MeasureAs=WebAudioDelayNode] attribute DelayNodeConstructor DelayNode;
     [MeasureAs=WebAudioDynamicsCompressorNode] attribute DynamicsCompressorNodeConstructor DynamicsCompressorNode;
     [MeasureAs=WebAudioGainNode] attribute GainNodeConstructor GainNode;
     [MeasureAs=WebAudioIIRFilterNode] attribute IIRFilterNodeConstructor IIRFilterNode;
     [MeasureAs=WebAudioMediaElementAudioSourceNode] attribute MediaElementAudioSourceNodeConstructor MediaElementAudioSourceNode;
     [MeasureAs=WebAudioOscillatorNode] attribute OscillatorNodeConstructor OscillatorNode;
     [MeasureAs=WebAudioPannerNode] attribute PannerNodeConstructor PannerNode;
     [MeasureAs=WebAudioPeriodicWave] attribute PeriodicWaveConstructor PeriodicWave;
     [MeasureAs=WebAudioStereoPannerNode] attribute StereoPannerNodeConstructor StereoPannerNode;
     [MeasureAs=WebAudioWaveShaperNode] attribute WaveShaperNodeConstructor WaveShaperNode;
 };