Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2573593002:
Chrome Mash: Use absolute path to run chrome executable (Closed)
|
Created:
4 years ago by Ken Rockot(use gerrit already) Modified:
4 years ago Reviewers:
sky CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChrome Mash: Use absolute path to run chrome executable
The child process launcher now switches to the host executable's
path before running a new child process. That breaks mash_runner
code which launches the host executable if the host executable was
invoked by relative path.
This changes mash_runner to always reference the host executable
by absolute path when rewriting child command lines.
BUG=None
R=sky@chromium.org
Committed: https://crrev.com/312059d83c311964f70a83d068990b2fc076bde4
Cr-Commit-Position: refs/heads/master@{#437961}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Description was changed from ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. This breaks mash_runner code launches the host executable if the host executable was invoked with a relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org ========== to ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. This breaks mash_runner code which launches the host executable if the host executable was invoked with a relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org ==========
Description was changed from ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. This breaks mash_runner code which launches the host executable if the host executable was invoked with a relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org ========== to ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. That breaks mash_runner code which launches the host executable if the host executable was invoked with a relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org ==========
Description was changed from ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. That breaks mash_runner code which launches the host executable if the host executable was invoked with a relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org ========== to ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. That breaks mash_runner code which launches the host executable if the host executable was invoked by relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by rockot@chromium.org
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481577114724690, "parent_rev":
"e7b7ce19767cabee639c97503624c84248ef7848", "commit_rev":
"62e24726ce13701d11e1709ac5336a47df6b4f23"}
Message was sent while issue was closed.
Description was changed from ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. That breaks mash_runner code which launches the host executable if the host executable was invoked by relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org ========== to ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. That breaks mash_runner code which launches the host executable if the host executable was invoked by relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org Review-Url: https://codereview.chromium.org/2573593002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. That breaks mash_runner code which launches the host executable if the host executable was invoked by relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org Review-Url: https://codereview.chromium.org/2573593002 ========== to ========== Chrome Mash: Use absolute path to run chrome executable The child process launcher now switches to the host executable's path before running a new child process. That breaks mash_runner code which launches the host executable if the host executable was invoked by relative path. This changes mash_runner to always reference the host executable by absolute path when rewriting child command lines. BUG=None R=sky@chromium.org Committed: https://crrev.com/312059d83c311964f70a83d068990b2fc076bde4 Cr-Commit-Position: refs/heads/master@{#437961} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/312059d83c311964f70a83d068990b2fc076bde4 Cr-Commit-Position: refs/heads/master@{#437961} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
