Make media controls not depend on the webkitfullscreenchange event

Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started by Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813
Committed: https://crrev.com/fb076a85441fa682dada999e283ff22d36ee4563
Cr-Commit-Position: refs/heads/master@{#436949}

[foolip, 2016-12-07 11:33:14]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 11:33:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-12-07 12:46:32]

Description was changed from

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

BUG=383813
==========

to

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started in Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813
==========

[foolip, 2016-12-07 12:47:03]

Description was changed from

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started in Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813
==========

to

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started by Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813
==========

[foolip, 2016-12-07 12:48:21]

foolip@chromium.org changed reviewers:
+ mlamouri@chromium.org

[foolip, 2016-12-07 12:48:22]

PTAL. This is a failing test in https://codereview.chromium.org/2557943002 but
I'm fixing it separately.

[commit-bot: I haz the power, 2016-12-07 12:54:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 12:54:11]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-12-07 14:42:18]

lgtm

[foolip, 2016-12-07 14:48:04]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:52:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481122084221940, "parent_rev":
"f320064fe9021ebb351cc37614b0ff2df952f839", "commit_rev":
"f1c6886d9f602380c15507b41506cc4b68ea3497"}

[commit-bot: I haz the power, 2016-12-07 14:52:58]

Description was changed from

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started by Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813
==========

to

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started by Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813
==========

[commit-bot: I haz the power, 2016-12-07 14:52:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 14:54:35]

Description was changed from

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started by Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813
==========

to

==========
Make media controls not depend on the webkitfullscreenchange event

With the unprefixed API, a fullscreenchange event will be fired at the
document, so this is not a reliable signal that the video element is
fullscreen.

Background: HTMLMediaElement::didEnterFullscreen() is called as part of
Fullscreen::didEnterFullscreen(), while the webkitfullscreenchange event
is fired on a timer started by Fullscreen::didEnterFullscreen().

Both before and after this change, the webkitfullscreenchange event is
fired after the post-enter MediaControls::notifyPanelWidthChanged().

Before, HTMLMediaElement::preDispatchEventHandler() called
configureMediaControls(), which would run
MediaControls::computeWhichControlsFit() with the new panel width and
update the visibility of the overflow button.

Now, MediaControls::panelWidthChangedTimerFired() will run
computeWhichControlsFit() after the event has been fired.

The difference isn't observable to web content, and it's still the case
that the media controls depend on layout to update, giving one bad frame
after entering fullscreen (or any other size-changing layout).

BUG=383813

Committed: https://crrev.com/fb076a85441fa682dada999e283ff22d36ee4563
Cr-Commit-Position: refs/heads/master@{#436949}
==========

[commit-bot: I haz the power, 2016-12-07 14:54:36]

Patchset 1 (id:??) landed as
https://crrev.com/fb076a85441fa682dada999e283ff22d36ee4563
Cr-Commit-Position: refs/heads/master@{#436949}