third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html - Issue 2557043003: Make media controls not depend on the webkitfullscreenchange event

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html

Issue 2557043003: Make media controls not depend on the webkitfullscreenchange event (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Clicking on the overflow fullscreen button opens the video in fullscreen. </title>	2 <title>Clicking on the overflow fullscreen button opens the video in fullscreen. </title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-controls.js"></script>	5 <script src="media-controls.js"></script>

6 <script src="media-file.js"></script>	6 <script src="media-file.js"></script>

7 <script src="overflow-menu.js"></script>	7 <script src="overflow-menu.js"></script>

8	8

9 <!--Padding ensures the overflow menu is visible for the tests. -->	9 <!--Padding ensures the overflow menu is visible for the tests. -->

10 <body style="padding-top: 200px; padding-left: 100px">	10 <body style="padding-top: 200px; padding-left: 100px">

(...skipping 10 matching lines...) Expand all Loading...
21 var overflowMenu = getOverflowMenuButton(video);	21 var overflowMenu = getOverflowMenuButton(video);

22	22

23 // Click on the overflow menu button	23 // Click on the overflow menu button

24 var coords = elementCoordinates(overflowMenu);	24 var coords = elementCoordinates(overflowMenu);

25 clickAtCoordinates(coords[0], coords[1]);	25 clickAtCoordinates(coords[0], coords[1]);

26	26

27 // Clicking on the fullscreen button should open up the video in fullscreen	27 // Clicking on the fullscreen button should open up the video in fullscreen

28 var coords = elementCoordinates(overflowList.children[OverflowMenuButtons.FU LLSCREEN]);	28 var coords = elementCoordinates(overflowList.children[OverflowMenuButtons.FU LLSCREEN]);

29 clickAtCoordinates(coords[0], coords[1]);	29 clickAtCoordinates(coords[0], coords[1]);

30	30

31 document.onwebkitfullscreenchange = t.step_func_done(() => {	31 document.onwebkitfullscreenchange = t.step_func(() => {

32 assert_equals(document.fullscreenElement, video);	32 assert_equals(document.fullscreenElement, video);

33 assert_equals(getComputedStyle(overflowMenu).display, "none");	33 // Hiding the overflow menu is triggered by layout.

	34 testRunner.layoutAndPaintAsyncThen(t.step_func_done(() => {

	35 assert_equals(getComputedStyle(overflowMenu).display, "none");

	36 }));

34 });	37 });

35 }));	38 }));

36 });	39 });

37 </script>	40 </script>

38 </body>	41 </body>

OLD	NEW