Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html

Issue 2557043003: Make media controls not depend on the webkitfullscreenchange event (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html
diff --git a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html
index db1fd28699ff161c5dea61fb878cb91dd5ba0ffa..30fccc14bf5a339a2118e566dcabadfa861a8861 100644
--- a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html
+++ b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html
@@ -28,9 +28,12 @@ async_test(function(t) {
var coords = elementCoordinates(overflowList.children[OverflowMenuButtons.FULLSCREEN]);
clickAtCoordinates(coords[0], coords[1]);
- document.onwebkitfullscreenchange = t.step_func_done(() => {
+ document.onwebkitfullscreenchange = t.step_func(() => {
assert_equals(document.fullscreenElement, video);
- assert_equals(getComputedStyle(overflowMenu).display, "none");
+ // Hiding the overflow menu is triggered by layout.
+ testRunner.layoutAndPaintAsyncThen(t.step_func_done(() => {
+ assert_equals(getComputedStyle(overflowMenu).display, "none");
+ }));
});
}));
});
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698