Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/nacl/renderer/ppb_nacl_private.h

Issue 2556983003: NaCl plugin: Make ServiceRuntime::Shutdown() kill the NaCl loader (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/ppb_nacl_private.h
diff --git a/components/nacl/renderer/ppb_nacl_private.h b/components/nacl/renderer/ppb_nacl_private.h
index 732c433c569bddc7814932184c386f5b73c1e373..c040e6bd346a76336da7d54e9e5ba22f20b0f261 100644
--- a/components/nacl/renderer/ppb_nacl_private.h
+++ b/components/nacl/renderer/ppb_nacl_private.h
@@ -205,6 +205,7 @@ struct PP_NaClFileInfo {
namespace nacl {
+
bbudge 2016/12/08 23:20:00 remove stray line
Derek Schuff 2016/12/09 00:11:34 Done.
// This is a set of interfaces used by the code in
// components/nacl/renderer/plugin/, implemented by
// components/nacl/renderer/.
@@ -281,6 +282,8 @@ class PPBNaClPrivate {
static void InstanceCreated(PP_Instance instance);
/* Performs internal cleanup when an instance is destroyed. */
static void InstanceDestroyed(PP_Instance instance);
+ /* Terminate the NaCl loader process associated with the instance */
bbudge 2016/12/08 23:20:00 nit: Terminates
Derek Schuff 2016/12/09 00:11:34 Done.
+ static void TerminateNaClLoader(PP_Instance instance);
/* Returns the kind of SFI sandbox implemented by NaCl on this
* platform.
*/

Powered by Google App Engine
This is Rietveld 408576698