NaCl plugin: Make ServiceRuntime::Shutdown() kill the NaCl loader

components/nacl/renderer/ppb_nacl_private.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_RENDERER_PPB_NACL_PRIVATE_H_
 #define COMPONENTS_NACL_RENDERER_PPB_NACL_PRIVATE_H_
 
 #include <memory>
 
 #include "base/process/process_handle.h"
@@ skipping 187 matching lines @@
   /* See NaClFileToken comment in nacl_process_host.h */
   uint64_t token_lo;
   uint64_t token_hi;
 };
 /**
  * @}
  */
 
 namespace nacl {
 
+

[bbudge, 2016/12/08 23:20:00]

remove stray line

[Derek Schuff, 2016/12/09 00:11:34]

Done.

 // This is a set of interfaces used by the code in
 // components/nacl/renderer/plugin/, implemented by
 // components/nacl/renderer/.
 //
 // There is not really a good name for this set of interfaces because the
 // grouping exists only for historical reasons.  It used to be a PPAPI
 // PPB_* interface (PPB_NaCl_Private) because the code in plugin/ used to
 // live outside the Chromium repo and used to be built as a separate
 // DSO/DLL.  Since that's no longer the case, there is now no strong
 // distinction between renderer/ and renderer/plugin/.
@@ skipping 56 matching lines @@
                             uint64_t loaded_bytes,
                             uint64_t total_bytes);
   /* Report an error that occured while attempting to load a nexe. */
   static void ReportLoadError(PP_Instance instance,
                               PP_NaClError error,
                               const char* error_message);
   /* Performs internal setup when an instance is created. */
   static void InstanceCreated(PP_Instance instance);
   /* Performs internal cleanup when an instance is destroyed. */
   static void InstanceDestroyed(PP_Instance instance);
+  /* Terminate the NaCl loader process associated with the instance */

[bbudge, 2016/12/08 23:20:00]

nit: Terminates

[Derek Schuff, 2016/12/09 00:11:34]

Done.

+  static void TerminateNaClLoader(PP_Instance instance);
   /* Returns the kind of SFI sandbox implemented by NaCl on this
    * platform.
    */
   static const char* GetSandboxArch(void);
   /* Initializes internal state for a NaCl plugin. */
   static void InitializePlugin(PP_Instance instance,
                                uint32_t argc,
                                const char* argn[],
                                const char* argv[]);
   /* Requests the NaCl manifest specified in the plugin arguments. */
@@ skipping 53 matching lines @@
                          const char* pexe_url,
                          int32_t opt_level,
                          PP_Bool use_subzero,
                          const struct PPP_PexeStreamHandler_1_0* stream_handler,
                          void* stream_handler_user_data);
 };
 
 }  // namespace nacl
 
 #endif  /* COMPONENTS_NACL_RENDERER_PPB_NACL_PRIVATE_H_ */