NaCl plugin: Make ServiceRuntime::Shutdown() kill the NaCl loader

components/nacl/renderer/ppb_nacl_private_impl.cc

Index: components/nacl/renderer/ppb_nacl_private_impl.cc
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index 801279e3884461b9d8f4ecd17e436ea1f0d5a123..8bb38b5f60bc0a13a7ee04e35bd0ada5c978ab9e 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -884,6 +884,13 @@ void PPBNaClPrivate::InstanceDestroyed(PP_Instance instance) {
   map.erase(iter);
 }
 
+// static
+void PPBNaClPrivate::TerminateNaClLoader(PP_Instance instance) {
+  auto* load_mgr = GetNexeLoadManager(instance);

[bbudge, 2016/12/08 23:20:00]

nit: is * necessary?

[Derek Schuff, 2016/12/09 00:11:34]

It's not necessary but it's good practice to use auto* or auto& when applicable
to avoid accidentally copying objects (especially after a refactor, etc).

[bbudge, 2016/12/09 00:19:43]

OK

+  if (load_mgr)
+    load_mgr->close_trusted_plugin_channel();
+}
+
 namespace {
 
 PP_Bool NaClDebugEnabledForURL(const char* alleged_nmf_url) {