Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2556973002: Allow specifying ColorBehavior to ImageSource (Closed)

Created:
4 years ago by ccameron
Modified:
4 years ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow specifying ColorBehavior to ImageSource This patch has no functional change, but will allow subsequent patches to specify a different target color space depending on their application (e.g, canvas and WebGL can request sRGB, and raster can request the output device behavior). BUG=667420 Committed: https://crrev.com/80eae1dfec8262cb7cc2f585d85d1d41a63a1168 Cr-Commit-Position: refs/heads/master@{#437514}

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Rebase #

Patch Set 4 : Change includes #

Patch Set 5 : Format #

Patch Set 6 : Update runtime features and layout tests #

Patch Set 7 : Rebase again #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 2 3 4 5 6 7 9 chunks +42 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp View 1 2 3 2 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 4 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 36 (27 generated)
ccameron
4 years ago (2016-12-08 01:24:57 UTC) #15
ccameron
ptal -- fairly simple change. The bigger ones come next.
4 years ago (2016-12-08 01:25:15 UTC) #16
ccameron
ping on this
4 years ago (2016-12-08 20:04:52 UTC) #21
Justin Novosad
lgtm
4 years ago (2016-12-09 02:23:56 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556973002/120001
4 years ago (2016-12-09 03:32:24 UTC) #26
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-09 05:09:23 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556973002/140001
4 years ago (2016-12-09 09:17:34 UTC) #31
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years ago (2016-12-09 10:49:43 UTC) #34
commit-bot: I haz the power
4 years ago (2016-12-09 10:51:17 UTC) #36
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/80eae1dfec8262cb7cc2f585d85d1d41a63a1168
Cr-Commit-Position: refs/heads/master@{#437514}

Powered by Google App Engine
This is Rietveld 408576698