Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/ImageSource.cpp

Issue 2556973002: Allow specifying ColorBehavior to ImageSource (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/ImageSource.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * Copyright (C) 2007 Alp Toker <alp.toker@collabora.co.uk> 3 * Copyright (C) 2007 Alp Toker <alp.toker@collabora.co.uk>
4 * Copyright (C) 2008, Google Inc. All rights reserved. 4 * Copyright (C) 2008, Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
11 * 2. Redistributions in binary form must reproduce the above copyright 11 * 2. Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the 12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution. 13 * documentation and/or other materials provided with the distribution.
14 * 14 *
15 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 15 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
16 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 16 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
17 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 17 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
18 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 18 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
19 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 19 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
20 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 20 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
22 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 22 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
23 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 23 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
24 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 24 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
25 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 #include "platform/graphics/ImageSource.h" 28 #include "platform/graphics/ImageSource.h"
29 29
30 #include "platform/RuntimeEnabledFeatures.h"
31 #include "platform/graphics/DeferredImageDecoder.h" 30 #include "platform/graphics/DeferredImageDecoder.h"
32 #include "platform/image-decoders/ImageDecoder.h" 31 #include "platform/image-decoders/ImageDecoder.h"
33 #include "third_party/skia/include/core/SkImage.h" 32 #include "third_party/skia/include/core/SkImage.h"
34 33
35 namespace blink { 34 namespace blink {
36 35
37 ImageSource::ImageSource() {} 36 ImageSource::ImageSource()
37 : m_decoderColorBehavior(ColorBehavior::transformToGlobalTarget()) {}
38 38
39 ImageSource::~ImageSource() {} 39 ImageSource::~ImageSource() {}
40 40
41 size_t ImageSource::clearCacheExceptFrame(size_t clearExceptFrame) { 41 size_t ImageSource::clearCacheExceptFrame(size_t clearExceptFrame) {
42 return m_decoder ? m_decoder->clearCacheExceptFrame(clearExceptFrame) : 0; 42 return m_decoder ? m_decoder->clearCacheExceptFrame(clearExceptFrame) : 0;
43 } 43 }
44 44
45 PassRefPtr<SharedBuffer> ImageSource::data() { 45 PassRefPtr<SharedBuffer> ImageSource::data() {
46 return m_decoder ? m_decoder->data() : nullptr; 46 return m_decoder ? m_decoder->data() : nullptr;
47 } 47 }
48 48
49 bool ImageSource::setData(PassRefPtr<SharedBuffer> passData, 49 bool ImageSource::setData(PassRefPtr<SharedBuffer> passData,
50 bool allDataReceived) { 50 bool allDataReceived) {
51 RefPtr<SharedBuffer> data = passData; 51 RefPtr<SharedBuffer> data = passData;
52 m_allDataReceived = allDataReceived;
52 53
53 if (m_decoder) { 54 if (m_decoder) {
54 m_decoder->setData(data.release(), allDataReceived); 55 m_decoder->setData(data.release(), allDataReceived);
55 // If the decoder is pre-instantiated, it means we've already validated the 56 // If the decoder is pre-instantiated, it means we've already validated the
56 // data/signature at some point. 57 // data/signature at some point.
57 return true; 58 return true;
58 } 59 }
59 60
60 if (RuntimeEnabledFeatures::colorCorrectRenderingEnabled()) { 61 m_decoder = DeferredImageDecoder::create(data, allDataReceived,
61 m_decoder = DeferredImageDecoder::create(data, allDataReceived, 62 ImageDecoder::AlphaPremultiplied,
62 ImageDecoder::AlphaPremultiplied, 63 m_decoderColorBehavior);
63 ColorBehavior::tag());
64 } else {
65 m_decoder = DeferredImageDecoder::create(
66 data, allDataReceived, ImageDecoder::AlphaPremultiplied,
67 ColorBehavior::transformToGlobalTarget());
68 }
69 64
70 // Insufficient data is not a failure. 65 // Insufficient data is not a failure.
71 return m_decoder || !ImageDecoder::hasSufficientDataToSniffImageType(*data); 66 return m_decoder || !ImageDecoder::hasSufficientDataToSniffImageType(*data);
72 } 67 }
73 68
74 String ImageSource::filenameExtension() const { 69 String ImageSource::filenameExtension() const {
75 return m_decoder ? m_decoder->filenameExtension() : String(); 70 return m_decoder ? m_decoder->filenameExtension() : String();
76 } 71 }
77 72
78 bool ImageSource::isSizeAvailable() { 73 bool ImageSource::isSizeAvailable() {
(...skipping 28 matching lines...) Expand all
107 } 102 }
108 103
109 int ImageSource::repetitionCount() { 104 int ImageSource::repetitionCount() {
110 return m_decoder ? m_decoder->repetitionCount() : cAnimationNone; 105 return m_decoder ? m_decoder->repetitionCount() : cAnimationNone;
111 } 106 }
112 107
113 size_t ImageSource::frameCount() const { 108 size_t ImageSource::frameCount() const {
114 return m_decoder ? m_decoder->frameCount() : 0; 109 return m_decoder ? m_decoder->frameCount() : 0;
115 } 110 }
116 111
117 sk_sp<SkImage> ImageSource::createFrameAtIndex(size_t index) { 112 sk_sp<SkImage> ImageSource::createFrameAtIndex(
113 size_t index,
114 const ColorBehavior& colorBehavior) {
118 if (!m_decoder) 115 if (!m_decoder)
119 return nullptr; 116 return nullptr;
120 117
118 if (colorBehavior != m_decoderColorBehavior) {
119 m_decoder = DeferredImageDecoder::create(data(), m_allDataReceived,
120 ImageDecoder::AlphaPremultiplied,
121 colorBehavior);
122 m_decoderColorBehavior = colorBehavior;
123 // The data has already been validated, so changing the color behavior
124 // should always result in a valid decoder.
125 DCHECK(m_decoder);
126 }
127
121 return m_decoder->createFrameAtIndex(index); 128 return m_decoder->createFrameAtIndex(index);
122 } 129 }
123 130
124 float ImageSource::frameDurationAtIndex(size_t index) const { 131 float ImageSource::frameDurationAtIndex(size_t index) const {
125 if (!m_decoder) 132 if (!m_decoder)
126 return 0; 133 return 0;
127 134
128 // Many annoying ads specify a 0 duration to make an image flash as quickly as 135 // Many annoying ads specify a 0 duration to make an image flash as quickly as
129 // possible. We follow Firefox's behavior and use a duration of 100 ms for any 136 // possible. We follow Firefox's behavior and use a duration of 100 ms for any
130 // frames that specify a duration of <= 10 ms. See <rdar://problem/7689300> 137 // frames that specify a duration of <= 10 ms. See <rdar://problem/7689300>
(...skipping 15 matching lines...) Expand all
146 153
147 bool ImageSource::frameIsCompleteAtIndex(size_t index) const { 154 bool ImageSource::frameIsCompleteAtIndex(size_t index) const {
148 return m_decoder && m_decoder->frameIsCompleteAtIndex(index); 155 return m_decoder && m_decoder->frameIsCompleteAtIndex(index);
149 } 156 }
150 157
151 size_t ImageSource::frameBytesAtIndex(size_t index) const { 158 size_t ImageSource::frameBytesAtIndex(size_t index) const {
152 return m_decoder ? m_decoder->frameBytesAtIndex(index) : 0; 159 return m_decoder ? m_decoder->frameBytesAtIndex(index) : 0;
153 } 160 }
154 161
155 } // namespace blink 162 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/ImageSource.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698