Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2556803002:
Making WTH::InitCompositor() protected instead of public. (Closed)
|
Created:
4 years ago by mfomitchev Modified:
4 years ago Reviewers:
sky CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMaking WTH::InitCompositor() protected instead of public.
BUG=NONE
Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65
Committed: https://crrev.com/7028deb3d93dd008eb00af461be74c39c8e36db9
Cr-Original-Commit-Position: refs/heads/master@{#437292}
Cr-Commit-Position: refs/heads/master@{#437818}
Patch Set 1 #Patch Set 2 : Calling InitHost() instead of InitCompositor() in a couple of places. #Patch Set 3 : Calling InitHost() instead of InitCompositor() in a couple of places. #
Total comments: 2
Patch Set 4 : Not calling Init in OnWmNewDisplay anymore - it's now done in WindowTreeClient::CreateWindowTreeHost #Patch Set 5 : Fixing upstream. #
Depends on Patchset: Messages
Total messages: 34 (21 generated)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mfomitchev@chromium.org changed reviewers: + sky@chromium.org
https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.cc File ash/mus/window_manager.cc (right): https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.... ash/mus/window_manager.cc:215: window_tree_host->InitHost(); Should we do this in WindowTreeClient::OnWmNewDisplay before it calls to the delegate?
https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.cc File ash/mus/window_manager.cc (right): https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.... ash/mus/window_manager.cc:215: window_tree_host->InitHost(); On 2016/12/06 17:58:02, sky wrote: > Should we do this in WindowTreeClient::OnWmNewDisplay before it calls to the > delegate? Ok, yeah, that would make sense. I'll do it in https://codereview.chromium.org/2552003002/ then, since that would fix some of the tests.
On 2016/12/06 18:01:18, mfomitchev wrote: > https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.cc > File ash/mus/window_manager.cc (right): > > https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.... > ash/mus/window_manager.cc:215: window_tree_host->InitHost(); > On 2016/12/06 17:58:02, sky wrote: > > Should we do this in WindowTreeClient::OnWmNewDisplay before it calls to the > > delegate? > > Ok, yeah, that would make sense. I'll do it in > https://codereview.chromium.org/2552003002/ then, since that would fix some of > the tests. Do you want to land that one first then and then update this patch?
On 2016/12/06 20:22:45, sky wrote: > On 2016/12/06 18:01:18, mfomitchev wrote: > > > https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.cc > > File ash/mus/window_manager.cc (right): > > > > > https://codereview.chromium.org/2556803002/diff/40001/ash/mus/window_manager.... > > ash/mus/window_manager.cc:215: window_tree_host->InitHost(); > > On 2016/12/06 17:58:02, sky wrote: > > > Should we do this in WindowTreeClient::OnWmNewDisplay before it calls to the > > > delegate? > > > > Ok, yeah, that would make sense. I'll do it in > > https://codereview.chromium.org/2552003002/ then, since that would fix some of > > the tests. > > Do you want to land that one first then and then update this patch? Yes. Just working on getting all tests to pass, then I will ping you on the other CL.
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by mfomitchev@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 70001, "attempt_start_ts": 1481221034692080,
"parent_rev": "fde832f3c8426dedb79a50b0cc0071ad852fd7b3", "commit_rev":
"8107479db0d132f9dc75ec9a60619a26d9064cd6"}
Message was sent while issue was closed.
Committed patchset #5 (id:70001)
Message was sent while issue was closed.
Description was changed from ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE ========== to ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Cr-Commit-Position: refs/heads/master@{#437292} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Cr-Commit-Position: refs/heads/master@{#437292}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:70001) has been created in https://codereview.chromium.org/2565563003/ by mfomitchev@chromium.org. The reason for reverting is: Reverting because https://codereview.chromium.org/2552003002/ needs to be reverted.
Message was sent while issue was closed.
Description was changed from ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Cr-Commit-Position: refs/heads/master@{#437292} ========== to ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Cr-Commit-Position: refs/heads/master@{#437292} ==========
The CQ bit was checked by mfomitchev@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 70001, "attempt_start_ts": 1481512995103190,
"parent_rev": "a8491243f43c3f31db2a47d8ca6749c7e8d8efb6", "commit_rev":
"5fb3d07cf560eb83c692e461116480b480e1f70d"}
Message was sent while issue was closed.
Description was changed from ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Cr-Commit-Position: refs/heads/master@{#437292} ========== to ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Cr-Commit-Position: refs/heads/master@{#437292} Review-Url: https://codereview.chromium.org/2556803002 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:70001)
Message was sent while issue was closed.
Description was changed from ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Cr-Commit-Position: refs/heads/master@{#437292} Review-Url: https://codereview.chromium.org/2556803002 ========== to ========== Making WTH::InitCompositor() protected instead of public. BUG=NONE Committed: https://crrev.com/98f0f335c82dbbd932d3d5bad9fbb22585dafb65 Committed: https://crrev.com/7028deb3d93dd008eb00af461be74c39c8e36db9 Cr-Original-Commit-Position: refs/heads/master@{#437292} Cr-Commit-Position: refs/heads/master@{#437818} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/7028deb3d93dd008eb00af461be74c39c8e36db9 Cr-Commit-Position: refs/heads/master@{#437818} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
