Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2552003002:
Ensure compositor initialized before WindowTreeHost is Shown. (Closed)
|
Created:
4 years ago by mfomitchev Modified:
4 years ago CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnsure compositor initialized before WindowTreeHost is Shown.
This is merely a sanity check. Technically you could show the host
without initializing it, but chances are you didn't meant to do that (or
you can easily change your code to Init before Show).
BUG=NONE
Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac
Committed: https://crrev.com/8187cbdf8d26caf89020f0e388f722edce4cb557
Cr-Original-Commit-Position: refs/heads/master@{#437285}
Cr-Commit-Position: refs/heads/master@{#437713}
Patch Set 1 #Patch Set 2 : Adding a comment #
Total comments: 1
Patch Set 3 : Addressing feedback, fixing tests. #Patch Set 4 : InitHost in more tests. #Patch Set 5 : Fixing typo #Patch Set 6 : Commenting out parts of tests and adding TODOs. #Patch Set 7 : Fixing WindowServerTest.EstablishConnectionViaFactory #
Messages
Total messages: 50 (39 generated)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== NOT FOR REVIEW BUG=NONE ========== to ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE ==========
Description was changed from ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE ========== to ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE ==========
sadrul@chromium.org changed reviewers: + sadrul@chromium.org
I think this is good. lgtm with the tests fixed. https://codereview.chromium.org/2552003002/diff/20001/ui/aura/window_tree_hos... File ui/aura/window_tree_host.cc (right): https://codereview.chromium.org/2552003002/diff/20001/ui/aura/window_tree_hos... ui/aura/window_tree_host.cc:214: CHECK(compositor()); DCHECK() should be fine here too.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sky - can you PTAL?
sky@chromium.org changed reviewers: + sky@chromium.org
LGTM
The CQ bit was checked by mfomitchev@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/2552003002/#ps100001 (title: "Commenting out parts of tests and adding TODOs.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481220497533770,
"parent_rev": "5b973eaff859669b96e23d9b94320beab781517f", "commit_rev":
"9e32f8cad9652d51d05054b0a6c59f3371da9423"}
Message was sent while issue was closed.
Description was changed from ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE ========== to ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE ========== to ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Cr-Commit-Position: refs/heads/master@{#437285} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Cr-Commit-Position: refs/heads/master@{#437285}
Message was sent while issue was closed.
FYI: Findit identified this CL at revision 437285 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2565583002/ by mfomitchev@chromium.org. The reason for reverting is: Caused a test to fail.
Message was sent while issue was closed.
Description was changed from ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Cr-Commit-Position: refs/heads/master@{#437285} ========== to ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Cr-Commit-Position: refs/heads/master@{#437285} ==========
The CQ bit was checked by mfomitchev@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2552003002/#ps120001 (title: "Fixing WindowServerTest.EstablishConnectionViaFactory")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481323302768190,
"parent_rev": "3cd6654d79d3a0e4760a9e3a5a8502e11c308622", "commit_rev":
"7ba113e10e862d3b50cc1999c4c550a8bbc53324"}
Message was sent while issue was closed.
Description was changed from ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Cr-Commit-Position: refs/heads/master@{#437285} ========== to ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Cr-Commit-Position: refs/heads/master@{#437285} Review-Url: https://codereview.chromium.org/2552003002 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Cr-Commit-Position: refs/heads/master@{#437285} Review-Url: https://codereview.chromium.org/2552003002 ========== to ========== Ensure compositor initialized before WindowTreeHost is Shown. This is merely a sanity check. Technically you could show the host without initializing it, but chances are you didn't meant to do that (or you can easily change your code to Init before Show). BUG=NONE Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac Committed: https://crrev.com/8187cbdf8d26caf89020f0e388f722edce4cb557 Cr-Original-Commit-Position: refs/heads/master@{#437285} Cr-Commit-Position: refs/heads/master@{#437713} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/8187cbdf8d26caf89020f0e388f722edce4cb557 Cr-Commit-Position: refs/heads/master@{#437713} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
