Fix a bug where image viewer custom tab has a wrong return stack

Fix a bug where image viewer custom tab has a wrong return stack

DownloadUtils fires a custom tab intent with a new task flag, yet we did not
support multiple tasks for CCT before. This CL is a rebase of
https://chromiumcodereview.appspot.com/2373823002/, and credit goes to
tedchoc@.

BUG=663841
Committed: https://crrev.com/a53b5cd4e3693faf88db6b2b953c515ab8db097c
Cr-Commit-Position: refs/heads/master@{#439641}

[Ian Wen, 2016-12-06 23:38:30]

ianwen@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ian Wen, 2016-12-06 23:38:31]

PTAL :)

[Ted C, 2016-12-07 18:46:57]

lgtm

https://codereview.chromium.org/2556713003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://codereview.chromium.org/2556713003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:376:
newIntent.setClassName(context, SeparateTaskCustomTabActivity.class.getName());
A thing to keep in mind is that SeparateTaskCustomTabActivity updates the task
description based on the title/theme/favicon of the current page.  In Custom
Tabs from external apps, we might want to keep the title the same as the calling
app (if a session is available).

Filed a bug to discuss as it outside the scope here:
crbug.com/672155

[Ian Wen, 2016-12-07 18:53:19]

cc yusufo@ as FYI

[Ian Wen, 2016-12-07 18:53:23]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2016-12-07 18:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 20:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 20:29:50]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2016-12-07 23:28:04]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 23:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 00:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:55:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ted C, 2016-12-10 00:03:52]

https://codereview.chromium.org/2556713003/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/2556713003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:64:
e.printStackTrace();
add a fail(""); here

[Ian Wen, 2016-12-20 00:11:22]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-12-20 00:11:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2556713003/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2016-12-20 00:11:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 00:50:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482192682285060,
"parent_rev": "e143cfdb83f8ccd6041cd937d3a548c20a3afb3c", "commit_rev":
"29dedc594bf1f6eee5d14cc4e576127a22d5efd8"}

[commit-bot: I haz the power, 2016-12-20 00:51:30]

Description was changed from

==========
Fix a bug where image viewer custom tab has a wrong return stack

DownloadUtils fires a custom tab intent with a new task flag, yet we did not
support multiple tasks for CCT before. This CL is a rebase of
https://chromiumcodereview.appspot.com/2373823002/, and credit goes to
tedchoc@.

BUG=663841
==========

to

==========
Fix a bug where image viewer custom tab has a wrong return stack

DownloadUtils fires a custom tab intent with a new task flag, yet we did not
support multiple tasks for CCT before. This CL is a rebase of
https://chromiumcodereview.appspot.com/2373823002/, and credit goes to
tedchoc@.

BUG=663841

Review-Url: https://codereview.chromium.org/2556713003
==========

[commit-bot: I haz the power, 2016-12-20 00:51:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 00:55:50]

Description was changed from

==========
Fix a bug where image viewer custom tab has a wrong return stack

DownloadUtils fires a custom tab intent with a new task flag, yet we did not
support multiple tasks for CCT before. This CL is a rebase of
https://chromiumcodereview.appspot.com/2373823002/, and credit goes to
tedchoc@.

BUG=663841

Review-Url: https://codereview.chromium.org/2556713003
==========

to

==========
Fix a bug where image viewer custom tab has a wrong return stack

DownloadUtils fires a custom tab intent with a new task flag, yet we did not
support multiple tasks for CCT before. This CL is a rebase of
https://chromiumcodereview.appspot.com/2373823002/, and credit goes to
tedchoc@.

BUG=663841

Committed: https://crrev.com/a53b5cd4e3693faf88db6b2b953c515ab8db097c
Cr-Commit-Position: refs/heads/master@{#439641}
==========

[commit-bot: I haz the power, 2016-12-20 00:55:51]

Patchset 3 (id:??) landed as
https://crrev.com/a53b5cd4e3693faf88db6b2b953c515ab8db097c
Cr-Commit-Position: refs/heads/master@{#439641}