Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3239)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Issue 2556713003: Fix a bug where image viewer custom tab has a wrong return stack (Closed)
Patch Set: fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
index 25361c603046edc3b82154364245c9900d05c819..3c25a62d517bb7dd68005afecdfd9c05baf06f75 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
@@ -1448,7 +1448,7 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
@Override
public void run() {
assertFalse(WarmupManager.getInstance().hasSpareWebContents());
- final CustomTabActivity activity = (CustomTabActivity) getActivity();
+ final CustomTabActivity activity = getActivity();
activity.finishAndClose(false);
}
});
@@ -1731,12 +1731,6 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
&& newActivity.getActivityTab().equals(tabToBeReparented);
}
}));
- CriteriaHelper.pollUiThread((new Criteria() {
- @Override
- public boolean isSatisfied() {
- return mActivity.isActivityDestroyed();
- }
- }));
assertEquals(newActivity.getWindowAndroid(), tabToBeReparented.getWindowAndroid());
assertEquals(newActivity.getWindowAndroid(),
tabToBeReparented.getContentViewCore().getWindowAndroid());

Powered by Google App Engine
This is Rietveld 408576698