Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2556413002:
Remove spam log when querying free/total size. (Closed)
DescriptionRemove spam log when querying free/total size.
Some mount points are virtual, and do not store bytes on the local
file system.
TEST=None
BUG=653593
Committed: https://crrev.com/4e6ad92801908ff7c689f327f445bde810f521a8
Cr-Commit-Position: refs/heads/master@{#438758}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Reverted accidential change. #
Total comments: 1
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove spam log when querying free/total size. Some mount points are virtual, and do not store bytes on the local file system. TEST=None BUG=653593 ========== to ========== Remove spam log when querying free/total size. Some mount points are virtual, and do not store bytes on the local file system. TEST=None BUG=653593 ==========
mtomasz@chromium.org changed reviewers: + atwilson@chromium.org
@atwilson: PTAL. Thanks.
LGTM except for one (unintentional?) comment change you should revert. https://codereview.chromium.org/2556413002/diff/1/chrome/browser/chromeos/pol... File chrome/browser/chromeos/policy/device_status_collector.cc (right): https://codereview.chromium.org/2556413002/diff/1/chrome/browser/chromeos/pol... chrome/browser/chromeos/policy/device_status_collector.cc:302: // reference to the instance of this class, so that the destru undo this change
https://codereview.chromium.org/2556413002/diff/1/chrome/browser/chromeos/pol... File chrome/browser/chromeos/policy/device_status_collector.cc (right): https://codereview.chromium.org/2556413002/diff/1/chrome/browser/chromeos/pol... chrome/browser/chromeos/policy/device_status_collector.cc:302: // reference to the instance of this class, so that the destru On 2016/12/14 16:09:25, Andrew T Wilson (Slow) wrote: > undo this change Done.
The CQ bit was checked by mtomasz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from atwilson@chromium.org Link to the patchset: https://codereview.chromium.org/2556413002/#ps20001 (title: "Reverted accidential change.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481779082153930,
"parent_rev": "03ba8070f81a85d8f3183c1abc7ae4352ecc56e5", "commit_rev":
"455882f9a2d7eb999b42b987206c75c7b60e10b3"}
Message was sent while issue was closed.
Description was changed from ========== Remove spam log when querying free/total size. Some mount points are virtual, and do not store bytes on the local file system. TEST=None BUG=653593 ========== to ========== Remove spam log when querying free/total size. Some mount points are virtual, and do not store bytes on the local file system. TEST=None BUG=653593 Review-Url: https://codereview.chromium.org/2556413002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove spam log when querying free/total size. Some mount points are virtual, and do not store bytes on the local file system. TEST=None BUG=653593 Review-Url: https://codereview.chromium.org/2556413002 ========== to ========== Remove spam log when querying free/total size. Some mount points are virtual, and do not store bytes on the local file system. TEST=None BUG=653593 Committed: https://crrev.com/4e6ad92801908ff7c689f327f445bde810f521a8 Cr-Commit-Position: refs/heads/master@{#438758} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4e6ad92801908ff7c689f327f445bde810f521a8 Cr-Commit-Position: refs/heads/master@{#438758}
Message was sent while issue was closed.
wez@chromium.org changed reviewers: + wez@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2556413002/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/policy/device_status_collector.cc (right): https://codereview.chromium.org/2556413002/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/policy/device_status_collector.cc:115: if (mount_point.empty() || !base::PathExists(mount_path)) nit: It'd be more readable to check mount_path.empty() here. If a mount point isn't on the local filesystem then should we even be going so far as to create a FilePath for it? Is there some cleaner way to check, e.g. some standard non-local filesystem prefix..? |
