Remove spam log when querying free/total size.

chrome/browser/chromeos/policy/device_status_collector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_status_collector.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 90 matching lines @@
   return (out_time - Time::UnixEpoch()).InMilliseconds();
 }
 
 // Helper function (invoked via blocking pool) to fetch information about
 // mounted disks.
 std::vector<em::VolumeInfo> GetVolumeInfo(
     const std::vector<std::string>& mount_points) {
   std::vector<em::VolumeInfo> result;
   for (const std::string& mount_point : mount_points) {
     base::FilePath mount_path(mount_point);
+
+    // Non-native file systems do not have a mount point in the local file
+    // system. However, it's worth checking here, as it's easier than checking
+    // earlier which mount point is local, and which one is not.
+    if (mount_point.empty() || !base::PathExists(mount_path))
+      continue;
+
     int64_t free_size = base::SysInfo::AmountOfFreeDiskSpace(mount_path);
     int64_t total_size = base::SysInfo::AmountOfTotalDiskSpace(mount_path);
     if (free_size < 0 || total_size < 0) {
-      LOG_IF(ERROR, !mount_point.empty()) << "Unable to get volume status for "
-                                          << mount_point;
+      LOG(ERROR) << "Unable to get volume status for " << mount_point;
       continue;
     }
     em::VolumeInfo info;
     info.set_volume_id(mount_point);
     info.set_storage_total(total_size);
     info.set_storage_free(free_size);
     result.push_back(info);
   }
   return result;
 }
@@ skipping 160 matching lines @@
 }  // namespace
 
 namespace policy {
 
 // Helper class for state tracking of async status queries. Creates device and
 // session status blobs in the constructor and sends them to the the status
 // response callback in the destructor.
 //
 // Some methods like |SampleVolumeInfo| queue async queries to collect data. The
 // response callback of these queries, e.g. |OnVolumeInfoReceived|, holds a
-// reference to the instance of this class, so that the destructor will not be
+// reference to the instance of this class, so that the destru

[Andrew T Wilson (Slow), 2016/12/14 16:09:25]

undo this change

[mtomasz, 2016/12/15 05:17:30]

Done.

 // invoked and the status response callback will not be fired until the original
 // owner of the instance releases its reference and all async queries finish.
 //
 // Therefore, if you create an instance of this class, make sure to release your
 // reference after quering all async queries (if any), e.g. by using a local
 // |scoped_refptr<GetStatusState>| and letting it go out of scope.
 class GetStatusState : public base::RefCountedThreadSafe<GetStatusState> {
  public:
   explicit GetStatusState(
       const scoped_refptr<base::SequencedTaskRunner> task_runner,
@@ skipping 882 matching lines @@
 
 void DeviceStatusCollector::OnOSVersion(const std::string& version) {
   os_version_ = version;
 }
 
 void DeviceStatusCollector::OnOSFirmware(const std::string& version) {
   firmware_version_ = version;
 }
 
 }  // namespace policy