Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2556253006: Fix disk read violation when create GvrLayout (Closed)

Created:
4 years ago by bshe
Modified:
4 years ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix disk read violation when create GvrLayout BUG=672477 Committed: https://crrev.com/0bf687f58a550ce92910f72a922b74926767e650 Cr-Commit-Position: refs/heads/master@{#437561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java View 2 chunks +1 line, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java View 3 chunks +21 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bshe
Hi Micheal. Can you please take a look? Gvr moved the GvrAPI initialization to GvrLayout's ...
4 years ago (2016-12-08 16:10:57 UTC) #2
mthiesse
lgtm
4 years ago (2016-12-08 16:24:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556253006/1
4 years ago (2016-12-08 23:04:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/178170)
4 years ago (2016-12-08 23:22:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556253006/1
4 years ago (2016-12-09 16:03:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 16:34:54 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 13:51:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bf687f58a550ce92910f72a922b74926767e650
Cr-Commit-Position: refs/heads/master@{#437561}

Powered by Google App Engine
This is Rietveld 408576698