Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java

Issue 2556253006: Fix disk read violation when create GvrLayout (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java
index b09e067ada393dab828ea061a50679dc212f41ab..4a47640d960588a966a3639a98b17dccff42edb8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java
@@ -5,17 +5,13 @@
package org.chromium.chrome.browser.vr_shell;
import android.app.Activity;
-import android.os.StrictMode;
import com.google.vr.ndk.base.GvrLayout;
-import org.chromium.base.Log;
-
/**
* Creates an active GvrContext from a detached GvrLayout. This is used by magic window mode.
*/
public class NonPresentingGvrContextImpl implements NonPresentingGvrContext {
- private static final String TAG = "NPGvrContextImpl";
private GvrLayout mGvrLayout;
public NonPresentingGvrContextImpl(Activity activity) {
@@ -24,17 +20,7 @@ public class NonPresentingGvrContextImpl implements NonPresentingGvrContext {
@Override
public long getNativeGvrContext() {
- long nativeGvrContext = 0;
- StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
- try {
- nativeGvrContext = mGvrLayout.getGvrApi().getNativeGvrContext();
- } catch (Exception ex) {
- Log.e(TAG, "Unable to instantiate GvrApi", ex);
- return 0;
- } finally {
- StrictMode.setThreadPolicy(oldPolicy);
- }
- return nativeGvrContext;
+ return mGvrLayout.getGvrApi().getNativeGvrContext();
}
@Override
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698