cros: Fold EulaModel into EulaView.

cros: Fold EulaModel into EulaView.

EulaModel has only one derived type, EulaView.

BUG=672142
Review-Url: https://codereview.chromium.org/2556253002
Cr-Commit-Position: refs/heads/master@{#443755}
Committed: https://chromium.googlesource.com/chromium/src/+/e6eeb70e1252bdbed947ed41d027d377f8093dc9

[jdufault, 2016-12-07 20:17:43]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 20:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 20:22:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 20:22:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdufault, 2016-12-08 17:58:21]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 17:59:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:04:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdufault, 2017-01-12 23:22:07]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2017-01-12 23:23:18]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-01-12 23:23:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-01-12 23:23:27]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-13 00:34:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:34:16]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-13 19:52:46]

Description was changed from

==========
cros: Fold EulaModel into EulaView.

EulaModel has only one derived type, EulaView.

BUG=672142
==========

to

==========
cros: Fold EulaModel into EulaView.

EulaModel has only one derived type, EulaView.

BUG=672142
==========

[jdufault, 2017-01-13 19:52:46]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-01-13 19:53:53]

achuith@, PTAL. Pure refactoring, no functional change.

[achuithb, 2017-01-13 20:10:05]

lgtm

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/eula_screen.cc (right):

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/eula_screen.cc:22: constexpr const char
kUserActionAcceptButtonClicked[] = "accept-button";
Looks a bit crowded, a newline before this line may be nice

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/eula_screen.cc:25: }  // namespace
Drop comment since the namespace is small

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/eula_screen.h (right):

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/eula_screen.h:58: void OnUserAction(const
std::string& action_id) override;
These overrides (OnUserAction and OnContextKeyUpdated) belong with Show() and
Hide(). 

Can we make these overrides private? I assume they are accessed through a base
pointer.

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/mock_eula_screen.h (right):

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/mock_eula_screen.h:39: EulaScreen*
screen_;
= nullptr. It's not initialized in the ctor either.

[jdufault, 2017-01-14 00:03:22]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-01-14 00:03:22]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2556253002/#ps60001
(title: "Address comments")

[jdufault, 2017-01-14 00:03:29]

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/eula_screen.cc (right):

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/eula_screen.cc:22: constexpr const char
kUserActionAcceptButtonClicked[] = "accept-button";
On 2017/01/13 20:10:05, achuithb wrote:
> Looks a bit crowded, a newline before this line may be nice

Done.

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/eula_screen.cc:25: }  // namespace
On 2017/01/13 20:10:05, achuithb wrote:
> Drop comment since the namespace is small

Keeping since I added newlines. I can remove if you feel strongly.

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/eula_screen.h (right):

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/eula_screen.h:58: void OnUserAction(const
std::string& action_id) override;
On 2017/01/13 20:10:05, achuithb wrote:
> These overrides (OnUserAction and OnContextKeyUpdated) belong with Show() and
> Hide(). 
> 
> Can we make these overrides private? I assume they are accessed through a base
> pointer.

Done.

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/mock_eula_screen.h (right):

https://codereview.chromium.org/2556253002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/mock_eula_screen.h:39: EulaScreen*
screen_;
On 2017/01/13 20:10:05, achuithb wrote:
> = nullptr. It's not initialized in the ctor either.

Done.

[commit-bot: I haz the power, 2017-01-14 00:04:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 01:13:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484352202549300,
"parent_rev": "38dbc8d042479ec398cde8eecfa29b1bd29a0761", "commit_rev":
"e6eeb70e1252bdbed947ed41d027d377f8093dc9"}

[commit-bot: I haz the power, 2017-01-14 01:14:16]

Description was changed from

==========
cros: Fold EulaModel into EulaView.

EulaModel has only one derived type, EulaView.

BUG=672142
==========

to

==========
cros: Fold EulaModel into EulaView.

EulaModel has only one derived type, EulaView.

BUG=672142

Review-Url: https://codereview.chromium.org/2556253002
Cr-Commit-Position: refs/heads/master@{#443755}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6eeb70e1252bdbed947ed41d027...
==========

[commit-bot: I haz the power, 2017-01-14 01:14:17]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e6eeb70e1252bdbed947ed41d027...