Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2285)

Unified Diff: chrome/browser/chromeos/login/screens/eula_screen.h

Issue 2556253002: cros: Fold EulaModel into EulaView. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/eula_screen.h
diff --git a/chrome/browser/chromeos/login/screens/eula_screen.h b/chrome/browser/chromeos/login/screens/eula_screen.h
index 83a0d4a914666001476293dd3eb0769f2142ea20..4c03ebcec4dab494369bd68138212348e37688f3 100644
--- a/chrome/browser/chromeos/login/screens/eula_screen.h
+++ b/chrome/browser/chromeos/login/screens/eula_screen.h
@@ -10,16 +10,18 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "chrome/browser/chromeos/login/screens/base_screen.h"
-#include "chrome/browser/chromeos/login/screens/eula_model.h"
#include "chromeos/tpm/tpm_password_fetcher.h"
#include "components/login/screens/screen_context.h"
#include "url/gurl.h"
namespace chromeos {
+class BaseScreenDelegate;
+class EulaView;
+
// Representation independent class that controls OOBE screen showing EULA
// to users.
-class EulaScreen : public EulaModel, public TpmPasswordFetcherDelegate {
+class EulaScreen : public BaseScreen, public TpmPasswordFetcherDelegate {
public:
class Delegate {
public:
@@ -35,20 +37,31 @@ class EulaScreen : public EulaModel, public TpmPasswordFetcherDelegate {
EulaView* view);
~EulaScreen() override;
- // EulaModel implementation:
+ // Returns URL of the OEM EULA page that should be displayed using current
+ // locale and manifest. Returns empty URL otherwise.
+ GURL GetOemEulaUrl() const;
+
+ // Initiate TPM password fetch. Will call actor's OnPasswordFetched() when
+ // done.
+ void InitiatePasswordFetch();
+
+ // Returns true if usage statistics reporting is enabled.
+ bool IsUsageStatsEnabled() const;
+
+ // This method is called, when view is being destroyed. Note, if model
+ // is destroyed earlier then it has to call SetModel(NULL).
+ void OnViewDestroyed(EulaView* view);
+
+ private:
+ // BaseScreen implementation:
void Show() override;
void Hide() override;
- GURL GetOemEulaUrl() const override;
- void InitiatePasswordFetch() override;
- bool IsUsageStatsEnabled() const override;
- void OnViewDestroyed(EulaView* view) override;
void OnUserAction(const std::string& action_id) override;
void OnContextKeyUpdated(const ::login::ScreenContext::KeyType& key) override;
// TpmPasswordFetcherDelegate implementation:
void OnPasswordFetched(const std::string& tpm_password) override;
- private:
// URL of the OEM EULA page (on disk).
GURL oem_eula_page_;
« no previous file with comments | « chrome/browser/chromeos/login/screens/eula_model.cc ('k') | chrome/browser/chromeos/login/screens/eula_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698