Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Added 2 changes in mac files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
index 9e5967225dbfca72a4a27c36a00a9bc5e1b00cbb..dcaffa8b6ff971ced3818124a3a5c0f87c24e9db 100644
--- a/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
@@ -167,7 +167,7 @@ LayoutRect InlineFlowBoxPainter::paintRectForImageStrip(
// off.
LayoutUnit logicalOffsetOnLine;
LayoutUnit totalLogicalWidth;
- if (direction == LTR) {
+ if (direction == TextDirection::Ltr) {
for (const InlineFlowBox* curr = m_inlineFlowBox.prevLineBox(); curr;
curr = curr->prevLineBox())
logicalOffsetOnLine += curr->logicalWidth();
@@ -301,8 +301,8 @@ void InlineFlowBoxPainter::paintBoxDecorationBackground(
// FIXME: What the heck do we do with RTL here? The math we're using is
// obviously not right, but it isn't even clear how this should work at
// all.
- LayoutRect imageStripPaintRect =
- paintRectForImageStrip(adjustedPaintOffset, frameRect.size(), LTR);
+ LayoutRect imageStripPaintRect = paintRectForImageStrip(
+ adjustedPaintOffset, frameRect.size(), TextDirection::Ltr);
GraphicsContextStateSaver stateSaver(paintInfo.context);
paintInfo.context.clip(adjustedClipRect);
BoxPainter::paintBorder(
@@ -387,8 +387,8 @@ void InlineFlowBoxPainter::paintMask(const PaintInfo& paintInfo,
// We have a mask image that spans multiple lines.
// FIXME: What the heck do we do with RTL here? The math we're using is
// obviously not right, but it isn't even clear how this should work at all.
- LayoutRect imageStripPaintRect =
- paintRectForImageStrip(adjustedPaintOffset, frameRect.size(), LTR);
+ LayoutRect imageStripPaintRect = paintRectForImageStrip(
+ adjustedPaintOffset, frameRect.size(), TextDirection::Ltr);
FloatRect clipRect(clipRectForNinePieceImageStrip(
m_inlineFlowBox, maskNinePieceImage, paintRect));
GraphicsContextStateSaver stateSaver(paintInfo.context);

Powered by Google App Engine
This is Rietveld 408576698