third_party/WebKit/Source/core/paint/ThemePainterMac.mm - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ThemePainterMac.mm

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Added 2 changes in mac files Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/ThemePainterMac.mm

diff --git a/third_party/WebKit/Source/core/paint/ThemePainterMac.mm b/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

index 45af2658e0aed00a95dc3d03b09243da822abfaf..46acd495d809e382be6d1d372fcf2e9f3cd97257 100644

--- a/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

+++ b/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

@@ -135,7 +135,7 @@ bool ThemePainterMac::paintCapsLockIndicator(const LayoutObject& o,

CGFloat minX = CGRectGetMinX(cgr);

CGFloat minY = CGRectGetMinY(cgr);

CGFloat heightScale = r.height() / kSquareSize;

- bool isRTL = o.styleRef().direction() == RTL;

sashab 2016/12/07 05:40:26 here

+ const bool isRTL = o.styleRef().direction() == TextDirection::Rtl;

CGAffineTransform transform =

CGAffineTransformMake(heightScale, 0, // A B

0, heightScale, // C D