third_party/WebKit/Source/core/layout/LayoutThemeMac.mm - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Added 2 changes in mac files Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

diff --git a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm b/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

index 6522ad8f39d5fa9a6af31c113780ee77299012ea..ac6dc91b65653f6bbf6806ad08ae35dc25678cc2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

+++ b/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

@@ -485,7 +485,7 @@ bool LayoutThemeMac::isControlStyled(const ComputedStyle& style) const {

return true;

// NSPopUpButtonCell on macOS 10.9 doesn't support

// NSUserInterfaceLayoutDirectionRightToLeft.

- if (IsOS10_9() && style.direction() == RTL)

sashab 2016/12/07 05:40:26 ptal

+ if (IsOS10_9() && style.direction() == TextDirection::Rtl)

return true;

}

// Some other cells don't work well when scaled.