Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Added 2 changes in mac files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
index ad9bd2487eed0f17ed49d7671340eda4454959be..1f74f9ca5003d33af80051c5883fe1de955493ed 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
@@ -50,7 +50,7 @@ TEST_F(NGInlineNodeTest, SegmentASCII) {
NGLayoutInlineItem& item = box->Items()[0];
EXPECT_EQ(0u, item.StartOffset());
EXPECT_EQ(5u, item.EndOffset());
- EXPECT_EQ(LTR, item.Direction());
+ EXPECT_EQ(TextDirection::Ltr, item.Direction());
}
TEST_F(NGInlineNodeTest, SegmentHebrew) {
@@ -62,7 +62,7 @@ TEST_F(NGInlineNodeTest, SegmentHebrew) {
NGLayoutInlineItem& item = box->Items()[0];
EXPECT_EQ(0u, item.StartOffset());
EXPECT_EQ(5u, item.EndOffset());
- EXPECT_EQ(RTL, item.Direction());
+ EXPECT_EQ(TextDirection::Rtl, item.Direction());
}
TEST_F(NGInlineNodeTest, SegmentSplit1To2) {
@@ -74,11 +74,11 @@ TEST_F(NGInlineNodeTest, SegmentSplit1To2) {
NGLayoutInlineItem& item = box->Items()[0];
EXPECT_EQ(0u, item.StartOffset());
EXPECT_EQ(6u, item.EndOffset());
- EXPECT_EQ(LTR, item.Direction());
+ EXPECT_EQ(TextDirection::Ltr, item.Direction());
item = box->Items()[1];
EXPECT_EQ(6u, item.StartOffset());
EXPECT_EQ(11u, item.EndOffset());
- EXPECT_EQ(RTL, item.Direction());
+ EXPECT_EQ(TextDirection::Rtl, item.Direction());
}
TEST_F(NGInlineNodeTest, SegmentSplit3To4) {
@@ -92,19 +92,19 @@ TEST_F(NGInlineNodeTest, SegmentSplit3To4) {
NGLayoutInlineItem& item = box->Items()[0];
EXPECT_EQ(0u, item.StartOffset());
EXPECT_EQ(3u, item.EndOffset());
- EXPECT_EQ(LTR, item.Direction());
+ EXPECT_EQ(TextDirection::Ltr, item.Direction());
item = box->Items()[1];
EXPECT_EQ(3u, item.StartOffset());
EXPECT_EQ(6u, item.EndOffset());
- EXPECT_EQ(LTR, item.Direction());
+ EXPECT_EQ(TextDirection::Ltr, item.Direction());
item = box->Items()[2];
EXPECT_EQ(6u, item.StartOffset());
EXPECT_EQ(7u, item.EndOffset());
- EXPECT_EQ(RTL, item.Direction());
+ EXPECT_EQ(TextDirection::Rtl, item.Direction());
item = box->Items()[3];
EXPECT_EQ(7u, item.StartOffset());
EXPECT_EQ(11u, item.EndOffset());
- EXPECT_EQ(RTL, item.Direction());
+ EXPECT_EQ(TextDirection::Rtl, item.Direction());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698