Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Added 2 changes in mac files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
index 91664cbbc7928347fb35d61e32dc69a7c9dc0a28..07ac17dbc7319968f46a46934c049b19876faa90 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
@@ -83,7 +83,7 @@ void ComputeAbsoluteHorizontal(const NGConstraintSpace& space,
margin_left = LayoutUnit();
if (margin_right == NGSizeIndefinite)
margin_right = LayoutUnit();
- if (space.Direction() == LTR)
+ if (space.Direction() == TextDirection::Ltr)
left = LayoutUnit();
else
right = LayoutUnit();
@@ -99,7 +99,7 @@ void ComputeAbsoluteHorizontal(const NGConstraintSpace& space,
margin_right = margin_space / 2;
} else {
// Margins are negative.
- if (space.Direction() == LTR) {
+ if (space.Direction() == TextDirection::Ltr) {
margin_left = LayoutUnit();
margin_right = margin_space;
} else {
@@ -115,7 +115,7 @@ void ComputeAbsoluteHorizontal(const NGConstraintSpace& space,
// Are values overconstrained?
if (margin_left + margin_right != margin_space) {
// Relax the end.
- if (space.Direction() == LTR)
+ if (space.Direction() == TextDirection::Ltr)
right -= margin_left + margin_right - margin_space;
else
left -= margin_left + margin_right - margin_space;
@@ -138,7 +138,7 @@ void ComputeAbsoluteHorizontal(const NGConstraintSpace& space,
} else if (left == NGSizeIndefinite && right == NGSizeIndefinite) {
// Rule 2.
DCHECK_NE(width, NGSizeIndefinite);
- if (space.Direction() == LTR)
+ if (space.Direction() == TextDirection::Ltr)
left = static_start;
else
right = static_start;

Powered by Google App Engine
This is Rietveld 408576698