Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2555683002: Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
chrishtr, Xianzhu, pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2550333002/ ) Reason for revert: A lot of css tests started failing after this CL: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6264 Original issue's description: > Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #8 id:140001 of https://codereview.chromium.org/2549553002/ ) > > Reason for revert: > Breaks the following webkit_unit_tests: > TableCellPainterTest.CollapsedBorderAndOverflow > TablePainterTest.CollapsedBorderInterestRectChange > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0 > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2 > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2 > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0 > on WebKit Win x64 Builder (dbg) > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/99618 > > Original issue's description: > > Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting > > > > Checks that nothing should be painted if > > paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to > > catch under-invalidations caused by it. > > > > The verification also works during the first paint, so the existing > > layout tests have enough coverage for the function. > > > > Also fixed some check failures: > > - LayoutDetailsMarker: was actual under-invalidation. > > - LayoutView: as display item client of frame scroll corner. Was not an > > actual under-invalidation because scroll controls are invalidated > > separately, but change code to avoid the check failure. This is not > > applicable to rootLayerScrolling. > > - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume > > there is always SVG effects. > > > > Objects painted in SkPictureBuilder are not checked. One example is > > LayoutSVGResourceClipper which doesn't have any painting on the backing, > > but may output paint operations in SkPictureBuilder for the clipped > > object. > > > > BUG=669327 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e > > Cr-Commit-Position: refs/heads/master@{#436455} > > TBR=chrishtr@chromium.org,pdr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=669327 > > Committed: https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc > Cr-Commit-Position: refs/heads/master@{#436476} TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-scrollable-iframe-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
haraken
Created Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting
4 years ago (2016-12-06 06:58:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555683002/1
4 years ago (2016-12-06 06:58:58 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-06 06:59:26 UTC) #5
Failed to apply patch for
third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt:77
  error:
third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt:
patch does not apply

Patch:      
third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt
Index:
third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt
b/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt
index
b55dc8012f021cf3565032eec13316fecc3cbf14..aa5b6444955fdb3055c679a31637acbbd9ef4461
100644
---
a/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt
+++
b/third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt
@@ -18,8 +18,18 @@
         },
         {
           "object": "LayoutView #document",
+          "rect": [8, 193, 285, 200],
+          "reason": "incremental"
+        },
+        {
+          "object": "LayoutView #document",
           "rect": [8, 393, 285, 15],
           "reason": "scroll"
+        },
+        {
+          "object": "LayoutView #document",
+          "rect": [93, 108, 200, 285],
+          "reason": "incremental"
         },
         {
           "object": "LayoutView #document",
@@ -77,6 +87,10 @@
     {
       "object": "VerticalScrollbar",
       "reason": "scroll"
+    },
+    {
+      "object": "LayoutView #document",
+      "reason": "incremental"
     }
   ]
 }

Powered by Google App Engine
This is Rietveld 408576698