Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2555453003: cros: HTML fixes needed to reinitializing an existing lock WebUI. (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: HTML fixes needed to reinitializing an existing lock WebUI. See https://codereview.chromium.org/2512473004/ for additional context. BUG=669638 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a77510ea644f9233e91d0dd62b02bb659abd95a8 Cr-Commit-Position: refs/heads/master@{#437964}

Patch Set 1 : Initial upload #

Total comments: 8

Patch Set 2 : Address comments #

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/lock.js View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M ui/login/account_picker/screen_account_picker.js View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.css View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/login/screen_container.css View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (27 generated)
jdufault
achuith@, alemate@, PTAL. Thanks.
4 years ago (2016-12-07 18:12:01 UTC) #14
jdufault
xiyuan@ PTAL since achuith@ is OOO.
4 years ago (2016-12-09 19:20:58 UTC) #16
xiyuan
lgtm https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos/login/screens/user_selection_screen.cc File chrome/browser/chromeos/login/screens/user_selection_screen.cc (right): https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos/login/screens/user_selection_screen.cc#newcode274 chrome/browser/chromeos/login/screens/user_selection_screen.cc:274: // Forcibly refresh all of the user images, ...
4 years ago (2016-12-09 22:47:21 UTC) #17
Alexander Alekseev
lgtm with nits. https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/resources/chromeos/login/lock.js File chrome/browser/resources/chromeos/login/lock.js (right): https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/resources/chromeos/login/lock.js#newcode73 chrome/browser/resources/chromeos/login/lock.js:73: preloadPin: function() { nit: rename to ...
4 years ago (2016-12-10 01:26:49 UTC) #20
jdufault
https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos/login/screens/user_selection_screen.cc File chrome/browser/chromeos/login/screens/user_selection_screen.cc (right): https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos/login/screens/user_selection_screen.cc#newcode274 chrome/browser/chromeos/login/screens/user_selection_screen.cc:274: // Forcibly refresh all of the user images, as ...
4 years ago (2016-12-12 19:52:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555453003/60001
4 years ago (2016-12-12 23:37:01 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-12 23:58:37 UTC) #33
commit-bot: I haz the power
4 years ago (2016-12-13 00:01:10 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a77510ea644f9233e91d0dd62b02bb659abd95a8
Cr-Commit-Position: refs/heads/master@{#437964}

Powered by Google App Engine
This is Rietveld 408576698