cros: HTML fixes needed to reinitializing an existing lock WebUI.

cros: HTML fixes needed to reinitializing an existing lock WebUI.

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a77510ea644f9233e91d0dd62b02bb659abd95a8
Cr-Commit-Position: refs/heads/master@{#437964}

[jdufault, 2016-12-05 20:48:28]

Description was changed from

==========
IGNORE: webview-js-fixes

BUG=669638
==========

to

==========
IGNORE: webview-js-fixes

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-12-05 20:48:30]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 20:49:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-12-05 22:42:02]

Description was changed from

==========
IGNORE: webview-js-fixes

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: HTML fixes needed to reinitializing an existing lock WebUI.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-05 23:10:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 23:10:23]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-12-06 21:49:18]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-12-06 23:15:22]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-07 00:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:23:27]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-12-07 18:09:25]

Description was changed from

==========
cros: HTML fixes needed to reinitializing an existing lock WebUI.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: HTML fixes needed to reinitializing an existing lock WebUI.

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-12-07 18:10:44]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org, alemate@chromium.org

[jdufault, 2016-12-07 18:12:01]

achuith@, alemate@, PTAL. Thanks.

[jdufault, 2016-12-09 19:12:30]

jdufault@chromium.org changed reviewers:
+ xiyuan@chromium.org

[jdufault, 2016-12-09 19:20:58]

xiyuan@ PTAL since achuith@ is OOO.

[xiyuan, 2016-12-09 22:47:21]

lgtm

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/user_selection_screen.cc (right):

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/user_selection_screen.cc:274: // Forcibly
refresh all of the user images, as the handler_  instance may
nit: handler_ -> |handler_| and remove one extra space after it

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:903: //
delegate_ is null when we are preloading the lock screen. There may be no
nit: delegate_ -> |delegate_|

[jdufault, 2016-12-10 01:04:49]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 01:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-12-10 01:26:49]

lgtm with nits.

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/lock.js (right):

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/lock.js:73: preloadPin: function() {
nit: rename to preloadPinKeyboard

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:907:
chromeos::PinStorage* pin_storage =
I assume that you are only looaking at active user because this is a lock screen
and at the time the lock screen is preloaded only one user is active, aren't
you? Probably we need a comment here why only one user is checked for PIN.

[commit-bot: I haz the power, 2016-12-10 03:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 03:35:44]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-12-12 19:51:44]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2016-12-12 19:52:03]

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/user_selection_screen.cc (right):

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/user_selection_screen.cc:274: // Forcibly
refresh all of the user images, as the handler_  instance may
On 2016/12/09 22:47:21, xiyuan wrote:
> nit: handler_ -> |handler_| and remove one extra space after it

Done.

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/lock.js (right):

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/lock.js:73: preloadPin: function() {
On 2016/12/10 01:26:49, Alexander Alekseev wrote:
> nit: rename to preloadPinKeyboard 

Done.

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:903: //
delegate_ is null when we are preloading the lock screen. There may be no
On 2016/12/09 22:47:21, xiyuan wrote:
> nit: delegate_ -> |delegate_|

Done.

https://codereview.chromium.org/2555453003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:907:
chromeos::PinStorage* pin_storage =
On 2016/12/10 01:26:49, Alexander Alekseev wrote:
> I assume that you are only looaking at active user because this is a lock
screen
> and at the time the lock screen is preloaded only one user is active, aren't
> you? Probably we need a comment here why only one user is checked for PIN.

I've changed this to iterate over every user.

[commit-bot: I haz the power, 2016-12-12 19:52:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:06:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:06:07]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-12-12 23:35:49]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-12-12 23:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
alemate@chromium.org
Link to the patchset: https://codereview.chromium.org/2555453003/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-12-12 23:37:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:58:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481585749116360,
"parent_rev": "702e4d3bbf04f00e95e2e974c7d1503e1531168d", "commit_rev":
"0c99bdb1cf152861394cd46e3eaf6c729ec5fd47"}

[commit-bot: I haz the power, 2016-12-12 23:58:36]

Description was changed from

==========
cros: HTML fixes needed to reinitializing an existing lock WebUI.

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: HTML fixes needed to reinitializing an existing lock WebUI.

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2555453003
==========

[commit-bot: I haz the power, 2016-12-12 23:58:37]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-13 00:01:09]

Description was changed from

==========
cros: HTML fixes needed to reinitializing an existing lock WebUI.

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2555453003
==========

to

==========
cros: HTML fixes needed to reinitializing an existing lock WebUI.

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a77510ea644f9233e91d0dd62b02bb659abd95a8
Cr-Commit-Position: refs/heads/master@{#437964}
==========

[commit-bot: I haz the power, 2016-12-13 00:01:10]

Patchset 3 (id:??) landed as
https://crrev.com/a77510ea644f9233e91d0dd62b02bb659abd95a8
Cr-Commit-Position: refs/heads/master@{#437964}