Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2550263002: cros: Ensure task manager shows correct title for lock screen webview (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Ensure task manager shows correct title for lock screen webview See https://codereview.chromium.org/2512473004/ for additional context. BUG=669638 Committed: https://crrev.com/befe2a179ce10b19932e8d4743aa7f4971027bda Cr-Commit-Position: refs/heads/master@{#437969}

Patch Set 1 : Initial upload #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/ui/web_contents_forced_title.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/ui/web_contents_forced_title.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 3 chunks +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 33 (26 generated)
jdufault
achuith@, alemate@, PTAL. Thanks.
4 years ago (2016-12-07 18:12:06 UTC) #13
jdufault
xiyuan@ PTAL since achuith@ is OOO.
4 years ago (2016-12-09 19:21:02 UTC) #15
xiyuan
lgtm
4 years ago (2016-12-09 22:49:59 UTC) #16
Alexander Alekseev
lgtm
4 years ago (2016-12-10 01:29:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550263002/60001
4 years ago (2016-12-13 00:25:36 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-13 00:38:26 UTC) #31
commit-bot: I haz the power
4 years ago (2016-12-13 00:41:52 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/befe2a179ce10b19932e8d4743aa7f4971027bda
Cr-Commit-Position: refs/heads/master@{#437969}

Powered by Google App Engine
This is Rietveld 408576698