Correctly enable WebAPK updates when "installation from unknown sources" is disabled

Correctly enable WebAPK updates when "installation from unknown sources" is disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149
Committed: https://crrev.com/22fb742e75eb6134b0815f1d38b73aec8d628cb1
Cr-Commit-Position: refs/heads/master@{#439050}

[pkotwicz, 2016-12-07 22:25:21]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-12-07 22:26:51]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-12-07 22:26:51]

Xi, can you please take a look?

This CL depends on https://codereview.chromium.org/2544973002/ and
https://codereview.chromium.org/2515293004/

[Xi Han, 2016-12-08 14:25:05]

lgtm

[pkotwicz, 2016-12-08 14:48:06]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2016-12-08 14:48:06]

Dominick for OWNERS

[dominickn, 2016-12-09 04:47:44]

https://codereview.chromium.org/2555333002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
(right):

https://codereview.chromium.org/2555333002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:52:
if (isEnabled()) return false;
if WebAPKs are enabled.... updates are disabled?

[dominickn, 2016-12-09 04:49:12]

Also, please wrap the CL title and description.

[pkotwicz, 2016-12-09 23:03:10]

Description was changed from

==========
Enable WebAPK updates if using Google Play and "installation from unknown
sources" is disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be
enabled to work. This CL enables updating WebAPKs if the update is done via
Google Play regardless
of whether "Installation from Unknown Sources" is enabled.

BUG=662149
==========

to

==========
Enable WebAPK updates if using Google Play and "installation from unknown
sources" is disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149
==========

[pkotwicz, 2016-12-15 03:27:20]

Dominick, can you please take another look?

https://codereview.chromium.org/2555333002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
(right):

https://codereview.chromium.org/2555333002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:52:
if (isEnabled()) return false;
Thank you very much for catching!

[dominickn, 2016-12-15 03:31:19]

lgtm. Please wrap the CL description and shorten the title - maybe "Correctly
enable WebAPK updates" or something like that.

[pkotwicz, 2016-12-15 15:52:10]

Description was changed from

==========
Enable WebAPK updates if using Google Play and "installation from unknown
sources" is disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149
==========

to

==========
Correctly enable WebAPK updates when "installation from unknown sources" is
disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149
==========

[pkotwicz, 2016-12-15 15:53:03]

I used your suggestion. The title is shorter but still longer than 72 characters
:( I am bad at coming up with short CL titles

[pkotwicz, 2016-12-15 15:54:12]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-12-15 15:54:13]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2555333002/#ps40001
(title: "Merge branch 'master' into check_play_install_unknown_sources")

[commit-bot: I haz the power, 2016-12-15 15:54:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 17:11:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 17:11:28]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pkotwicz, 2016-12-16 05:01:37]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-12-16 05:01:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2555333002/#ps60001
(title: "Merge branch 'master' into check_play_install_unknown_sources")

[commit-bot: I haz the power, 2016-12-16 05:02:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 06:44:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481864497985470,
"parent_rev": "19d22aa70bc7b4e0bc4c44979552cdf7aa17a1fc", "commit_rev":
"28bdcf040e34e1dd7c9d90ba9c1572cba014b70e"}

[commit-bot: I haz the power, 2016-12-16 06:45:19]

Description was changed from

==========
Correctly enable WebAPK updates when "installation from unknown sources" is
disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149
==========

to

==========
Correctly enable WebAPK updates when "installation from unknown sources" is
disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149

Review-Url: https://codereview.chromium.org/2555333002
==========

[commit-bot: I haz the power, 2016-12-16 06:45:20]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-16 06:47:27]

Description was changed from

==========
Correctly enable WebAPK updates when "installation from unknown sources" is
disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149

Review-Url: https://codereview.chromium.org/2555333002
==========

to

==========
Correctly enable WebAPK updates when "installation from unknown sources" is
disabled

Installation / updating via Google Play does not require "Installation from
Unknown Sources" to be enabled to work. This CL enables updating WebAPKs if the
update is done via Google Play regardless of whether "Installation from Unknown
Sources" is enabled.

BUG=662149

Committed: https://crrev.com/22fb742e75eb6134b0815f1d38b73aec8d628cb1
Cr-Commit-Position: refs/heads/master@{#439050}
==========

[commit-bot: I haz the power, 2016-12-16 06:47:28]

Patchset 3 (id:??) landed as
https://crrev.com/22fb742e75eb6134b0815f1d38b73aec8d628cb1
Cr-Commit-Position: refs/heads/master@{#439050}