chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java - Issue 2555333002: Correctly enable WebAPK updates when "installation from unknown sources" is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

Issue 2555333002: Correctly enable WebAPK updates when "installation from unknown sources" is disabled (Closed)

Patch Set: Merge branch 'master' into check_play_install_unknown_sources Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

index 66c0bc540a1892dd807aa5024aab2ec9daed021d..f492fdfbf072222f1e799595a744d27c148f4e7a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

@@ -210,13 +210,7 @@ public class WebApkUpdateManager implements WebApkUpdateDataFetcher.Observer {

return true;

}

- // Updating WebAPKs requires "installation from unknown sources" to be enabled. It is

- // confusing for a user to see a dialog asking them to enable "installation from unknown

- // sources" when they are in the middle of using the WebAPK (as opposed to after requesting

- // to add a WebAPK to the homescreen).

- if (!installingFromUnknownSourcesAllowed()) {

- return false;

- }

+ if (!ChromeWebApkHost.areUpdatesEnabled()) return false;

if (isShellApkVersionOutOfDate(info)) return true;