Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2555103002: Rename InvalidatableInterpolation cache to be explicitly about value conversion (Closed)

Created:
4 years ago by alancutter (OOO until 2018)
Modified:
4 years ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename InvalidatableInterpolation cache to be explicitly about value conversion The cache naming in InvalidatableInterpolation is currently vague about what is being cached. This patch makes it more explicit that it's caching the keyframe value conversion. There are no behavioural changes made by this patch. This is in preparation for refactoring how InvalidatableInterpolations acquire their InterpolationTypes. BUG=671904 Committed: https://crrev.com/3a225dcd053a9b87e56c14d75e42df95fe78ae4b Cr-Commit-Position: refs/heads/master@{#437120}

Patch Set 1 #

Patch Set 2 : Whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp View 6 chunks +17 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
alancutter (OOO until 2018)
4 years ago (2016-12-07 06:22:25 UTC) #2
Eric Willigers
lgtm
4 years ago (2016-12-07 06:30:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103002/20001
4 years ago (2016-12-07 06:33:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/351391)
4 years ago (2016-12-07 08:46:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103002/20001
4 years ago (2016-12-07 23:27:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 01:40:34 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 01:44:22 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a225dcd053a9b87e56c14d75e42df95fe78ae4b
Cr-Commit-Position: refs/heads/master@{#437120}

Powered by Google App Engine
This is Rietveld 408576698