Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

Issue 2555103002: Rename InvalidatableInterpolation cache to be explicitly about value conversion (Closed)
Patch Set: Whitespace Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
diff --git a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
index 6307cce01185d5c7c4ff946cd7e84c95813caf79..1763d4648e7db27612ba0319e382fc8aa55a1147 100644
--- a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
+++ b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
@@ -49,18 +49,18 @@ class CORE_EXPORT InvalidatableInterpolation : public Interpolation {
m_startKeyframe(startKeyframe),
m_endKeyframe(endKeyframe),
m_currentFraction(std::numeric_limits<double>::quiet_NaN()),
- m_isCached(false) {}
+ m_isConversionCached(false) {}
using ConversionCheckers = InterpolationType::ConversionCheckers;
std::unique_ptr<TypedInterpolationValue> maybeConvertUnderlyingValue(
const InterpolationEnvironment&) const;
- const TypedInterpolationValue* ensureValidInterpolation(
+ const TypedInterpolationValue* ensureValidConversion(
const InterpolationEnvironment&,
const UnderlyingValueOwner&) const;
- void clearCache() const;
- bool isCacheValid(const InterpolationEnvironment&,
- const UnderlyingValueOwner&) const;
+ void clearConversionCache() const;
+ bool isConversionCacheValid(const InterpolationEnvironment&,
+ const UnderlyingValueOwner&) const;
bool isNeutralKeyframeActive() const;
std::unique_ptr<PairwisePrimitiveInterpolation> maybeConvertPairwise(
const InterpolationEnvironment&,
@@ -79,7 +79,7 @@ class CORE_EXPORT InvalidatableInterpolation : public Interpolation {
RefPtr<PropertySpecificKeyframe> m_startKeyframe;
RefPtr<PropertySpecificKeyframe> m_endKeyframe;
double m_currentFraction;
- mutable bool m_isCached;
+ mutable bool m_isConversionCached;
mutable std::unique_ptr<PrimitiveInterpolation> m_cachedPairConversion;
mutable ConversionCheckers m_conversionCheckers;
mutable std::unique_ptr<TypedInterpolationValue> m_cachedValue;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698