Fix visibility of minimized panels when restoring from overview.

Fix visibility of minimized panels when restoring from overview.

BUG=301879
TEST=WindowSelectorTest.MinimizedWindowVisibility
TEST=Minimize a panel / window. Enter and exit overview twice. Window should be visible both times.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226474

[flackr, 2013-10-01 16:09:12]

PTAL, let me know what you think. Personally I think this was better with
Layer::SetVisible(false) and then changing Window::Hide to update the window's
visible state even though the layer target visibility is already correct as in
https://chromiumcodereview.appspot.com/23654037/diff/1/ui/aura/window.cc. This
would be consistent with vollick@'s suggestion to update the layer visibility in
the same animation as the opacity change.

https://codereview.chromium.org/25551002/diff/1/ash/wm/overview/scoped_transf...
File ash/wm/overview/scoped_transform_overview_window.cc (right):

https://codereview.chromium.org/25551002/diff/1/ash/wm/overview/scoped_transf...
ash/wm/overview/scoped_transform_overview_window.cc:192:
window_->layer()->SetVisible(false);
This is really a workaround. I described the full circumstances in the bug.
vollick@ suggested that when animating opacity we should animation visibility at
the same time. However, as came up in
https://chromiumcodereview.appspot.com/23654037/diff/1/ui/aura/window.cc the
window visibility state does not change if the layer's visibility state is
already the target visibility. Alternately I could move the window_->Hide call
above setting the layer opacity to ensure the visibility gets changed as in
patchset 2.

[sky, 2013-10-01 17:47:27]

I'm pretty sure we do this in other places too. I agree it is unfortunate. LGTM

[commit-bot: I haz the power, 2013-10-01 17:58:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/25551002/4001

[commit-bot: I haz the power, 2013-10-01 19:51:27]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-01 19:57:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/25551002/4001

[commit-bot: I haz the power, 2013-10-01 20:55:57]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-01 22:59:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/25551002/4001

[commit-bot: I haz the power, 2013-10-01 23:43:15]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-01 23:56:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/25551002/4001

[commit-bot: I haz the power, 2013-10-02 00:30:12]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-02 10:59:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/25551002/4001

[commit-bot: I haz the power, 2013-10-02 16:07:48]

Change committed as 226474