Fix visibility of minimized panels when restoring from overview.

ash/wm/overview/scoped_transform_overview_window.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/scoped_transform_overview_window.h"
 
 #include "ash/shell.h"
 #include "ash/wm/window_state.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/screen_position_client.h"
@@ skipping 168 matching lines @@
     AnimateTransformOnWindowAndTransientChildren(original_transform_);
     window_copy_ = NULL;
     layer_ = NULL;
     if (minimized_ && window_->GetProperty(aura::client::kShowStateKey) !=
         ui::SHOW_STATE_MINIMIZED) {
       // Setting opacity 0 and visible false ensures that the property change
       // to SHOW_STATE_MINIMIZED will not animate the window from its original
       // bounds to the minimized position.
       window_->layer()->SetOpacity(0);
       window_->Hide();
+      // Hiding the window does not update the layer visibility because opacity
+      // is animating to 0 (See VisibilityController::UpdateLayerVisibility).
+      // Showing the window later requires that the layer visibility is false.
+      window_->layer()->SetVisible(false);

[flackr, 2013/10/01 16:09:12]

This is really a workaround. I described the full circumstances in the bug.
vollick@ suggested that when animating opacity we should animation visibility at
the same time. However, as came up in
https://chromiumcodereview.appspot.com/23654037/diff/1/ui/aura/window.cc the
window visibility state does not change if the layer's visibility state is
already the target visibility. Alternately I could move the window_->Hide call
above setting the layer opacity to ensure the visibility gets changed as in
patchset 2.

       window_->SetProperty(aura::client::kShowStateKey,
                            ui::SHOW_STATE_MINIMIZED);
     }
     ash::wm::GetWindowState(window_)->set_ignored_by_shelf(ignored_by_shelf_);
   } else if (window_copy_) {
     // If this class still owns a copy of the window, clean up the copy. This
     // will be the case if the window was destroyed.
     window_copy_->Close();
     if (layer_)
       views::corewm::DeepDeleteLayers(layer_);
@@ skipping 90 matching lines @@
     transient_child->SetTransform(transient_window_transform);
   }
 }
 
 void ScopedTransformOverviewWindow::OnOverviewStarted() {
   ash::wm::GetWindowState(window_)->set_ignored_by_shelf(true);
   RestoreWindow();
 }
 
 }  // namespace ash