Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2843)

Unified Diff: ash/wm/overview/scoped_transform_overview_window.cc

Issue 25551002: Fix visibility of minimized panels when restoring from overview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Alternate workaround. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/overview/scoped_transform_overview_window.cc
diff --git a/ash/wm/overview/scoped_transform_overview_window.cc b/ash/wm/overview/scoped_transform_overview_window.cc
index d596ccce4a9ba282aa84e3db1342af5eac856088..7c5a7a8948a7e6bd5a970df5ae464779953a8aa7 100644
--- a/ash/wm/overview/scoped_transform_overview_window.cc
+++ b/ash/wm/overview/scoped_transform_overview_window.cc
@@ -184,8 +184,11 @@ ScopedTransformOverviewWindow::~ScopedTransformOverviewWindow() {
// Setting opacity 0 and visible false ensures that the property change
// to SHOW_STATE_MINIMIZED will not animate the window from its original
// bounds to the minimized position.
- window_->layer()->SetOpacity(0);
+ // Hiding the window needs to be done before the target opacity is 0,
+ // otherwise the layer's visibility will not be updated
+ // (See VisibilityController::UpdateLayerVisibility).
window_->Hide();
+ window_->layer()->SetOpacity(0);
window_->SetProperty(aura::client::kShowStateKey,
ui::SHOW_STATE_MINIMIZED);
}
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698