Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2555043003: [tracing] Make TracedValue accept const char* strings (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
fmeawad, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tracing] Make TracedValue accept const char* strings This should speed up trace generation for cpu profile as it eliminates creation of temporary std::string objects. Review-Url: https://codereview.chromium.org/2555043003 Cr-Commit-Position: refs/heads/master@{#41736} Committed: https://chromium.googlesource.com/v8/v8/+/250e85f84abd24c4ddab2efc6aa0ddddab09c55d

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M src/tracing/traced-value.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/tracing/traced-value.cc View 3 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
alph
4 years ago (2016-12-07 08:09:22 UTC) #4
fmeawad
lgtm
4 years ago (2016-12-08 16:07:50 UTC) #15
Yang
On 2016/12/08 16:07:50, fmeawad wrote: > lgtm lgtm.
4 years ago (2016-12-08 16:30:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555043003/40001
4 years ago (2016-12-15 17:34:57 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-15 18:03:53 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/250e85f84abd24c4ddab2efc6aa0ddddab0...

Powered by Google App Engine
This is Rietveld 408576698