Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: src/tracing/traced-value.h

Issue 2555043003: [tracing] Make TracedValue accept const char* strings (Closed)
Patch Set: Rebaseline Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/tracing/traced-value.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/tracing/traced-value.h
diff --git a/src/tracing/traced-value.h b/src/tracing/traced-value.h
index befa387bc875c0dbb15c8c16f2776e6fd2cc823c..7de4c234a2420509e487906c27fe0db0be08ee69 100644
--- a/src/tracing/traced-value.h
+++ b/src/tracing/traced-value.h
@@ -29,14 +29,18 @@ class TracedValue : public ConvertableToTraceFormat {
void SetInteger(const char* name, int value);
void SetDouble(const char* name, double value);
void SetBoolean(const char* name, bool value);
- void SetString(const char* name, const std::string& value);
+ void SetString(const char* name, const char* value);
+ void SetString(const char* name, const std::string& value) {
+ SetString(name, value.c_str());
+ }
void BeginDictionary(const char* name);
void BeginArray(const char* name);
void AppendInteger(int);
void AppendDouble(double);
void AppendBoolean(bool);
- void AppendString(const std::string&);
+ void AppendString(const char*);
+ void AppendString(const std::string& value) { AppendString(value.c_str()); }
void BeginArray();
void BeginDictionary();
« no previous file with comments | « no previous file | src/tracing/traced-value.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698