UserGestureIndicator: remove many unnecessary calls to isMainThread

third_party/WebKit/Source/platform/UserGestureIndicator.h

Index: third_party/WebKit/Source/platform/UserGestureIndicator.h
diff --git a/third_party/WebKit/Source/platform/UserGestureIndicator.h b/third_party/WebKit/Source/platform/UserGestureIndicator.h
index 5cab2e0c690d05884219ad11a0204570c1b19ab7..909142d5ca8462f504ce70ebbf6b47548c5ac33a 100644
--- a/third_party/WebKit/Source/platform/UserGestureIndicator.h
+++ b/third_party/WebKit/Source/platform/UserGestureIndicator.h
@@ -94,11 +94,16 @@ class PLATFORM_EXPORT UserGestureIndicator final {
   WTF_MAKE_NONCOPYABLE(UserGestureIndicator);
 
  public:
+  enum ThreadCheck {
+    CheckThreadState,
+    DoNotCheckThreadState,
+  };
+
   // Returns whether a user gesture is currently in progress.
   // Does not invoke the UserGestureUtilizedCallback.  Consider calling
   // utilizeUserGesture instead if you know for sure that the return value
   // will have an effect.
-  static bool processingUserGesture();
+  static bool processingUserGesture(ThreadCheck = DoNotCheckThreadState);

[kinuko, 2016/12/09 03:15:51]

I slightly prefer having processingUserGestureThreadSafe here too over taking
additional argument.

[Charlie Harrison, 2016/12/09 15:24:14]

Do you feel that way for all the methods? i.e. should I just scrap the enum?

I've done so in the current patch.

 
   // Indicates that a user gesture (if any) is being used, without preventing it
   // from being used again.  Returns whether a user gesture is currently in
@@ -110,9 +115,9 @@ class PLATFORM_EXPORT UserGestureIndicator final {
   // it cannot be used again.  This is done only for very security-sensitive
   // operations like creating a new process.
   // Like utilizeUserGesture, may invoke/clear any UserGestureUtilizedCallback.
-  static bool consumeUserGesture();
+  static bool consumeUserGesture(ThreadCheck = DoNotCheckThreadState);
 
-  static UserGestureToken* currentToken();
+  static UserGestureToken* currentToken(ThreadCheck = DoNotCheckThreadState);
 
   explicit UserGestureIndicator(PassRefPtr<UserGestureToken>);
   ~UserGestureIndicator();