Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 2555013004: UserGestureIndicator: remove many unnecessary calls to isMainThread (Closed)
Patch Set: [test] remove isMainThread() check in currentToken() Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp
diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
index fd395173727def4b414ec276c8186b2d5fa99230..496dfa8c84c88126e508f2bd26442cd9c7fe9b89 100644
--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp
+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
@@ -156,7 +156,8 @@ ScriptPromise Permissions::request(ScriptState* scriptState,
service->RequestPermission(
std::move(descriptor),
scriptState->getExecutionContext()->getSecurityOrigin(),
- UserGestureIndicator::processingUserGesture(),
+ UserGestureIndicator::processingUserGesture(
+ UserGestureIndicator::CheckThreadState),
convertToBaseCallback(WTF::bind(
&Permissions::taskComplete, wrapPersistent(this),
wrapPersistent(resolver), passed(std::move(descriptorCopy)))));
@@ -247,7 +248,8 @@ ScriptPromise Permissions::requestAll(
service->RequestPermissions(
std::move(internalPermissions),
scriptState->getExecutionContext()->getSecurityOrigin(),
- UserGestureIndicator::processingUserGesture(),
+ UserGestureIndicator::processingUserGesture(
+ UserGestureIndicator::CheckThreadState),
convertToBaseCallback(WTF::bind(
&Permissions::batchTaskComplete, wrapPersistent(this),
wrapPersistent(resolver), passed(std::move(internalPermissionsCopy)),

Powered by Google App Engine
This is Rietveld 408576698