UserGestureIndicator: remove many unnecessary calls to isMainThread

third_party/WebKit/Source/platform/UserGestureIndicator.h

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 76 matching lines @@
   double m_timestamp;
   TimeoutPolicy m_timeoutPolicy;
   UserGestureUtilizedCallback* m_usageCallback;
 };
 
 class PLATFORM_EXPORT UserGestureIndicator final {
   USING_FAST_MALLOC(UserGestureIndicator);
   WTF_MAKE_NONCOPYABLE(UserGestureIndicator);
 
  public:
+  enum ThreadCheck {
+    CheckThreadState,
+    DoNotCheckThreadState,
+  };
+
   // Returns whether a user gesture is currently in progress.
   // Does not invoke the UserGestureUtilizedCallback.  Consider calling
   // utilizeUserGesture instead if you know for sure that the return value
   // will have an effect.
-  static bool processingUserGesture();
+  static bool processingUserGesture(ThreadCheck = DoNotCheckThreadState);

[kinuko, 2016/12/09 03:15:51]

I slightly prefer having processingUserGestureThreadSafe here too over taking
additional argument.

[Charlie Harrison, 2016/12/09 15:24:14]

Do you feel that way for all the methods? i.e. should I just scrap the enum?

I've done so in the current patch.

 
   // Indicates that a user gesture (if any) is being used, without preventing it
   // from being used again.  Returns whether a user gesture is currently in
   // progress.  If true, invokes (and then clears) any
   // UserGestureUtilizedCallback.
   static bool utilizeUserGesture();

[kinuko, 2016/12/09 03:15:51]

Should this also check ThreadCheck?

[Charlie Harrison, 2016/12/09 15:24:14]

If we go with the enum approach, sure. Otherwise I don't think any existing
callers need the thread safe version so I don't think we need
utilizeUserGestureThreadSafe.

 
   // Mark the current user gesture (if any) as having been used, such that
   // it cannot be used again.  This is done only for very security-sensitive
   // operations like creating a new process.
   // Like utilizeUserGesture, may invoke/clear any UserGestureUtilizedCallback.
-  static bool consumeUserGesture();
+  static bool consumeUserGesture(ThreadCheck = DoNotCheckThreadState);
 
-  static UserGestureToken* currentToken();
+  static UserGestureToken* currentToken(ThreadCheck = DoNotCheckThreadState);
 
   explicit UserGestureIndicator(PassRefPtr<UserGestureToken>);
   ~UserGestureIndicator();
 
  private:
   static UserGestureToken* s_rootToken;
 
   RefPtr<UserGestureToken> m_token;
 };
 
 }  // namespace blink
 
 #endif