Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2554873002: Mark correct tree-scope dirty removing link in shadow. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark correct tree-scope dirty removing link in shadow. Noticed while working on 567021, StyleElement found the correct tree-scope in from of a shadow root when applicable while HTMLLinkElement would just use the document. This is what kept us from being able to use AnalyzedStyleUpdate for removedFrom() for link elements. R=meade@chromium.org BUG=671596 Committed: https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff Cr-Commit-Position: refs/heads/master@{#437210}

Patch Set 1 #

Patch Set 2 : Avoid code duplication. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/host-link-style.html View 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleElement.cpp View 1 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
rune
ptal
4 years ago (2016-12-06 15:23:24 UTC) #7
meade_UTC10
lgtm
4 years ago (2016-12-07 22:52:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554873002/40001
4 years ago (2016-12-08 08:21:38 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 08:28:26 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-08 08:30:37 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff
Cr-Commit-Position: refs/heads/master@{#437210}

Powered by Google App Engine
This is Rietveld 408576698