Make setNeedsActiveStyleUpdate mark treescope dirty only.

Make setNeedsActiveStyleUpdate mark treescope dirty only.

Pass the treeScope instead of a stylesheet pointer and remove the
synchronous resolverChanged() call. Instead add the resolveChanged()
calls where currently necessary and mark them for removal.

This makes the setNeedsActiveStyleUpdate implementation like what we
want to end up with [1]. I've done it this way to make the following
CLs easier to review.

Also, setNeedsActiveStyleUpdate calls are removed where we call
removeStyleSheetCandidateNode() since that method already marks the
tree-scope dirty.

[1] https://codereview.chromium.org/1913833002/

R=meade@chromium.org
BUG=567021
Committed: https://crrev.com/11bf99aa6426685ed8bf15b98a2680b02a841455
Cr-Commit-Position: refs/heads/master@{#437212}

[rune, 2016-12-05 13:37:04]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:37:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 15:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 15:01:47]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2016-12-05 23:57:23]

I looked through this a bit to try to see why the DCHECK is being hit. I suspect
it'll need a little bit of adjustment to avoid hitting that...

https://codereview.chromium.org/2546393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StyleEngine.cpp (right):

https://codereview.chromium.org/2546393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StyleEngine.cpp:562:
DCHECK(m_styleSheetCollectionMap.contains(&scope));
It looks like this change is causing this DCHECK to be hit.

https://codereview.chromium.org/2546393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/2546393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLLinkElement.cpp:224:
document().styleEngine().setNeedsActiveStyleUpdate(treeScope());
It looks like the treeScope is not yet registered in the StyleEngine, which is
why the DCHECK I commented on is getting hit. Do you need to call 
document().styleEngine().styleSheetsForStyleSheetList(treeScope()) or 
move this call to before line 219?

[rune, 2016-12-06 14:53:22]

https://codereview.chromium.org/2546393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/2546393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLLinkElement.cpp:224:
document().styleEngine().setNeedsActiveStyleUpdate(treeScope());
On 2016/12/05 23:57:22, Eddy wrote:
> It looks like the treeScope is not yet registered in the StyleEngine, which is
> why the DCHECK I commented on is getting hit. Do you need to call 
> document().styleEngine().styleSheetsForStyleSheetList(treeScope()) or 
> move this call to before line 219?

It's the wrong treeScope(), we should have found the right ShadowRoot treeScope
for the removeStyleSheetCandidateNode(). I don't think we even need the
setNeedsActiveStyleUpdate call here since removeStyleSheetCandidateNode will do
that for us.

Anyway, needed to fix https://crbug.com/671596 first:

https://codereview.chromium.org/2551973003/

[rune, 2016-12-06 14:55:05]

On 2016/12/06 14:53:22, rune wrote:

> Anyway, needed to fix https://crbug.com/671596 first:
> 
> https://codereview.chromium.org/2551973003/

I meant: https://codereview.chromium.org/2554873002/

[rune, 2016-12-06 20:37:47]

Description was changed from

==========
Make setNeedsActiveStyleUpdate mark treescope dirty only.

Pass the treeScope instead of a stylesheet pointer and remove the
synchronous resolverChanged() call. Instead add the resolveChanged()
calls where currently necessary and mark them for removal.

This makes the setNeedsActiveStyleUpdate implementation like what we
want to end up with [1]. I've done it this way to make the following
CLs easier to review.

[1] https://codereview.chromium.org/1913833002/

R=meade@chromium.org
BUG=567021
==========

to

==========
Make setNeedsActiveStyleUpdate mark treescope dirty only.

Pass the treeScope instead of a stylesheet pointer and remove the
synchronous resolverChanged() call. Instead add the resolveChanged()
calls where currently necessary and mark them for removal.

This makes the setNeedsActiveStyleUpdate implementation like what we
want to end up with [1]. I've done it this way to make the following
CLs easier to review.

Also, setNeedsActiveStyleUpdate calls are removed where we call
removeStyleSheetCandidateNode() since that method already marks the
tree-scope dirty.

[1] https://codereview.chromium.org/1913833002/

R=meade@chromium.org
BUG=567021
==========

[rune, 2016-12-06 22:05:41]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 02:10:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 02:10:42]

Dry run: This issue passed the CQ dry run.

[rune, 2016-12-07 10:45:52]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 10:46:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 12:16:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 12:16:04]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2016-12-07 22:57:15]

lgtm

[rune, 2016-12-08 08:42:26]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-12-08 08:42:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 08:46:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481186546530360,
"parent_rev": "81a563ce2e70620fb1c90e38bc99a55de9a2a071", "commit_rev":
"111f53e12a0a3c7fb3fda0ddee6a7591cc25ee67"}

[commit-bot: I haz the power, 2016-12-08 08:47:23]

Description was changed from

==========
Make setNeedsActiveStyleUpdate mark treescope dirty only.

Pass the treeScope instead of a stylesheet pointer and remove the
synchronous resolverChanged() call. Instead add the resolveChanged()
calls where currently necessary and mark them for removal.

This makes the setNeedsActiveStyleUpdate implementation like what we
want to end up with [1]. I've done it this way to make the following
CLs easier to review.

Also, setNeedsActiveStyleUpdate calls are removed where we call
removeStyleSheetCandidateNode() since that method already marks the
tree-scope dirty.

[1] https://codereview.chromium.org/1913833002/

R=meade@chromium.org
BUG=567021
==========

to

==========
Make setNeedsActiveStyleUpdate mark treescope dirty only.

Pass the treeScope instead of a stylesheet pointer and remove the
synchronous resolverChanged() call. Instead add the resolveChanged()
calls where currently necessary and mark them for removal.

This makes the setNeedsActiveStyleUpdate implementation like what we
want to end up with [1]. I've done it this way to make the following
CLs easier to review.

Also, setNeedsActiveStyleUpdate calls are removed where we call
removeStyleSheetCandidateNode() since that method already marks the
tree-scope dirty.

[1] https://codereview.chromium.org/1913833002/

R=meade@chromium.org
BUG=567021
==========

[commit-bot: I haz the power, 2016-12-08 08:47:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-08 08:48:43]

Description was changed from

==========
Make setNeedsActiveStyleUpdate mark treescope dirty only.

Pass the treeScope instead of a stylesheet pointer and remove the
synchronous resolverChanged() call. Instead add the resolveChanged()
calls where currently necessary and mark them for removal.

This makes the setNeedsActiveStyleUpdate implementation like what we
want to end up with [1]. I've done it this way to make the following
CLs easier to review.

Also, setNeedsActiveStyleUpdate calls are removed where we call
removeStyleSheetCandidateNode() since that method already marks the
tree-scope dirty.

[1] https://codereview.chromium.org/1913833002/

R=meade@chromium.org
BUG=567021
==========

to

==========
Make setNeedsActiveStyleUpdate mark treescope dirty only.

Pass the treeScope instead of a stylesheet pointer and remove the
synchronous resolverChanged() call. Instead add the resolveChanged()
calls where currently necessary and mark them for removal.

This makes the setNeedsActiveStyleUpdate implementation like what we
want to end up with [1]. I've done it this way to make the following
CLs easier to review.

Also, setNeedsActiveStyleUpdate calls are removed where we call
removeStyleSheetCandidateNode() since that method already marks the
tree-scope dirty.

[1] https://codereview.chromium.org/1913833002/

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/11bf99aa6426685ed8bf15b98a2680b02a841455
Cr-Commit-Position: refs/heads/master@{#437212}
==========

[commit-bot: I haz the power, 2016-12-08 08:48:44]

Patchset 3 (id:??) landed as
https://crrev.com/11bf99aa6426685ed8bf15b98a2680b02a841455
Cr-Commit-Position: refs/heads/master@{#437212}