Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2554783002: Exclude wrap_memcpy.cc from BUILD.gn unconditionally (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
xyzzyz
CC:
chromium-reviews, ruiu
Target Ref:
refs/heads/chromium-deps/2016-10-25
Visibility:
Public.

Description

Exclude wrap_memcpy.cc from BUILD.gn unconditionally wrap_memcpy.cc is problematic for several reasons: * It's not used in the gn build, since no one sets up -Wl,-wrap,memcpy. * When it's in the main binary as a part of source_set, -Wl,-wrap,memcpy introduces infinity recursion on memcpy. * That causes link failure on LLD build in Chromium tree. BUG=661171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -7 lines 0 comments Download
M templates/BUILD.gn.template View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tzik
PTAL
4 years ago (2016-12-06 12:20:47 UTC) #4
xyzzyz
lgtm
4 years ago (2016-12-06 20:41:25 UTC) #5
tzik
On 2016/12/06 20:41:25, xyzzyz wrote: > lgtm Thanks! I think I don't have the permission ...
4 years ago (2016-12-07 01:22:07 UTC) #6
xyzzyz
On 2016/12/07 01:22:07, tzik wrote: > On 2016/12/06 20:41:25, xyzzyz wrote: > > lgtm > ...
4 years ago (2016-12-07 19:24:12 UTC) #7
tzik
4 years ago (2016-12-08 04:10:21 UTC) #8
On 2016/12/07 19:24:12, xyzzyz wrote:
> On 2016/12/07 01:22:07, tzik wrote:
> > On 2016/12/06 20:41:25, xyzzyz wrote:
> > > lgtm
> > 
> > Thanks!
> > I think I don't have the permission to land this. Could you do it for me?
> 
> Hm, I had some weird errors from git cl land when running on this issue. It
> seems that commit landed successfully, but it has me as an author, and this
> issue was not updated. I was probably using 'git cl' wrong, but other than
this,
> it should be fine:
>
https://chromium.googlesource.com/external/github.com/grpc/grpc/+/chromium-de...

Thanks again! No problem. So, let me close this and roll it.

Powered by Google App Engine
This is Rietveld 408576698