Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: templates/BUILD.gn.template

Issue 2554783002: Exclude wrap_memcpy.cc from BUILD.gn unconditionally (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/BUILD.gn.template
diff --git a/templates/BUILD.gn.template b/templates/BUILD.gn.template
index 55aec520e9c84bf06c673f435a135cda0832c20f..585e350f688145e0e3a00abe562fc399fb339617 100644
--- a/templates/BUILD.gn.template
+++ b/templates/BUILD.gn.template
@@ -144,15 +144,13 @@
% endfor
]
% if contains_wrap_memcpy(srcs):
- if (is_android) {
- # gRPC memcpy wrapping logic isn't Android-friendly.
- # See https://crbug.com/661171
- sources -= [
+ # gRPC memcpy wrapping logic isn't useful here.
+ # See https://crbug.com/661171
+ sources -= [
% for src in get_wrap_memcpy(srcs):
- "${src}",
+ "${src}",
% endfor
- ]
- }
+ ]
% endif
deps = [
% for dep in get_deps(lib):
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698