Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: BUILD.gn

Issue 2554783002: Exclude wrap_memcpy.cc from BUILD.gn unconditionally (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | templates/BUILD.gn.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index d9b5a483f622e1615aa4432d544b7be5adf54f94..99bc8572f772996c9035ce6b18d2095ba3a2751a 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -139,13 +139,11 @@ source_set("gpr") {
"src/core/lib/support/tmpfile_windows.c",
"src/core/lib/support/wrap_memcpy.c",
]
- if (is_android) {
- # gRPC memcpy wrapping logic isn't Android-friendly.
- # See https://crbug.com/661171
- sources -= [
- "src/core/lib/support/wrap_memcpy.c",
- ]
- }
+ # gRPC memcpy wrapping logic isn't useful here.
+ # See https://crbug.com/661171
+ sources -= [
+ "src/core/lib/support/wrap_memcpy.c",
+ ]
deps = [
]
configs -= [ "//build/config/compiler:chromium_code" ]
« no previous file with comments | « no previous file | templates/BUILD.gn.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698