Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2554343002: [runtime] Add instance size check for CheckEquivalent(). (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add instance size check for CheckEquivalent(). WASM exported functions have additional internal fields which change the instance size. Adding a getter or setter to such an exported function results in its map becoming normalized. The normalized map cache, however, finds a different map with a different instance size, and thus BOOM. R=verwaest@chromium.org,cbruni@chromium.org BUG= Committed: https://crrev.com/576abe14c673eefc4aaf3aaba4b4b670b1d87a12 Cr-Commit-Position: refs/heads/master@{#41691}

Patch Set 1 #

Patch Set 2 : Only check internal field count #

Patch Set 3 : Fix the header size calculation for modules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M src/objects.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/wasm/add-getters.js View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
titzer
PTAL, this is ready to go now.
4 years ago (2016-12-12 18:20:21 UTC) #13
Camillo Bruni
lgtm
4 years ago (2016-12-14 11:30:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554343002/40001
4 years ago (2016-12-14 11:30:24 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-14 11:58:57 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-14 12:00:02 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/576abe14c673eefc4aaf3aaba4b4b670b1d87a12
Cr-Commit-Position: refs/heads/master@{#41691}

Powered by Google App Engine
This is Rietveld 408576698